You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by ky...@apache.org on 2019/12/31 09:20:35 UTC

[incubator-weex-cli] branch master updated: fix(debug): fix 609 (#610)

This is an automated email from the ASF dual-hosted git repository.

kyork pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex-cli.git


The following commit(s) were added to refs/heads/master by this push:
     new 0654904  fix(debug): fix 609 (#610)
0654904 is described below

commit 0654904172e6fcad260fde3469fdcf1b1fcc1187
Author: 任跃兵 <cn...@live.cn>
AuthorDate: Tue Dec 31 17:20:26 2019 +0800

    fix(debug): fix 609 (#610)
---
 packages/@weex/plugins/debug/commands/debug.js | 2 +-
 packages/@weex/plugins/debug/src/index.js      | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/@weex/plugins/debug/commands/debug.js b/packages/@weex/plugins/debug/commands/debug.js
index 2a9866a..9be8b70 100644
--- a/packages/@weex/plugins/debug/commands/debug.js
+++ b/packages/@weex/plugins/debug/commands/debug.js
@@ -56,7 +56,7 @@ module.exports = {
               description: 'specify debug channel id'
             },
             {
-              key: '--manul',
+              key: '--manual',
               default: 'false',
               description: 'control open browser or not'
             },
diff --git a/packages/@weex/plugins/debug/src/index.js b/packages/@weex/plugins/debug/src/index.js
index e31d232..1e2b50a 100644
--- a/packages/@weex/plugins/debug/src/index.js
+++ b/packages/@weex/plugins/debug/src/index.js
@@ -22,7 +22,7 @@ function resolveConnectUrl (config) {
 exports.startServerAndLaunch = function (config, cb) {
   this.startServer(config).then(() => {
     cb && cb()
-    if (!config.manual) this.launch(config.ip, config.port)
+    this.launch(config.ip, config.port)
   })
 }
 
@@ -71,7 +71,7 @@ exports.launch = function (ip, port) {
       headless.launchHeadless(`${config.ip}:${config.port}`, open)
     })
   }
-  launcher.launchChrome(debuggerURL, config.REMOTE_DEBUG_PORT || 9222)
+  if (!config.manual) launcher.launchChrome(debuggerURL, config.REMOTE_DEBUG_PORT || 9222)
 }
 
 exports.reload = function () {