You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/01/02 12:18:24 UTC
[GitHub] [incubator-brpc] eric-buaa-cn opened a new pull request #1012:
bugfix: pid file may be overwritten
eric-buaa-cn opened a new pull request #1012: bugfix: pid file may be overwritten
URL: https://github.com/apache/incubator-brpc/pull/1012
The following step will mess up the pid file:
1. Start the server with pid file enabled. Suppose the pid is 12345.
2. Make the server core dump.
3. Restart the server. Suppose the new pid is 8888. The pid file will be overwritten with the wrong content 88885.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on issue #1012: bugfix: pid file
may be overwritten
Posted by GitBox <gi...@apache.org>.
jamesge commented on issue #1012: bugfix: pid file may be overwritten
URL: https://github.com/apache/incubator-brpc/pull/1012#issuecomment-570446316
Thanks for your fix 👍 , and I've checked other usages of `open`, which seem to be OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge merged pull request #1012: bugfix: pid
file may be overwritten
Posted by GitBox <gi...@apache.org>.
jamesge merged pull request #1012: bugfix: pid file may be overwritten
URL: https://github.com/apache/incubator-brpc/pull/1012
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org