You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/05/29 10:53:40 UTC

[GitHub] jcchavezs commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector

jcchavezs commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector
URL: https://github.com/apache/incubator-skywalking/pull/1273#discussion_r191381426
 
 

 ##########
 File path: apm-collector/apm-collector-boot/src/main/resources/application.yml
 ##########
 @@ -86,4 +86,11 @@ configuration:
     applicationAverageResponseTimeThreshold: 2000
 # thermodynamic
     thermodynamicResponseTimeStep: 50
-    thermodynamicCountOfResponseTimeSteps: 40
\ No newline at end of file
+    thermodynamicCountOfResponseTimeSteps: 40
+# TODO: receiver_zipkin need to remove before merge, and only provide this in document.
+receiver_zipkin:
 
 Review comment:
   Is it necessary to pass this information being structured? Can't you just pass the `endpoint` (e.g. `endpoint: http://localhost:9411/api/v2/spans`  as we usually do for zipkin? cc @adriancole @wu-sheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services