You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/05/11 13:18:43 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1639: SOLR-16394: Tweak backup listing, deletion to be more REST-ful
gerlowskija opened a new pull request, #1639:
URL: https://github.com/apache/solr/pull/1639
https://issues.apache.org/jira/browse/SOLR-16394
# Description
Solr has slowly been modifying its v2 APIs to align around a more REST-ful model. Many APIs have already been through this re-alignment but many more remain including backup-listing and deletion.
# Solution
This commit tweaks the list-backups and delete-backups v2 APIs to be more REST-ful. The APIs are now:
- List Backups - `GET /api/backups/bName/versions`
- Delete Backup By ID - `DELETE /api/backups/bName/versions/123
- Delete Backups By Recency - `DELETE /api/backups/bName/versions?retainLatest=3`
- Garbage Collect Orphaned - `PUT /api/backups/bName/purgeUnused`
# Tests
Existing backup/restore tests continue to pass. Additional tests added in `DeleteCollectionBackupAPITest`.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1639: SOLR-16394: Tweak backup listing, deletion to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1639:
URL: https://github.com/apache/solr/pull/1639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1639: SOLR-16394: Tweak backup listing, deletion to be more REST-ful
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1639:
URL: https://github.com/apache/solr/pull/1639#issuecomment-1549972757
Alright, tests and 'check' look good. Merging this now to main, will backport in a few days if fucit doesn't show any spikes in the backup-related tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org