You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/16 22:53:23 UTC
[GitHub] [spark] maropu commented on a change in pull request #27597:
[SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy
when insert into table
maropu commented on a change in pull request #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table
URL: https://github.com/apache/spark/pull/27597#discussion_r379940805
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -59,7 +60,8 @@ case class DataSourceAnalysis(conf: SQLConf) extends Rule[LogicalPlan] with Cast
sourceAttributes: Seq[Attribute],
providedPartitions: Map[String, Option[String]],
targetAttributes: Seq[Attribute],
- targetPartitionSchema: StructType): Seq[NamedExpression] = {
+ targetPartitionSchema: StructType,
+ conf: SQLConf): Seq[NamedExpression] = {
Review comment:
Why do we need conf here, the constructor has conf though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org