You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Sergey (JIRA)" <ji...@apache.org> on 2013/08/02 12:47:48 UTC

[jira] [Created] (PIG-3409) org.apache.pig.data.DefaultTuple hashcode perfomance issue

Sergey created PIG-3409:
---------------------------

             Summary: org.apache.pig.data.DefaultTuple hashcode perfomance issue
                 Key: PIG-3409
                 URL: https://issues.apache.org/jira/browse/PIG-3409
             Project: Pig
          Issue Type: Bug
          Components: impl
    Affects Versions: 0.11
            Reporter: Sergey
            Priority: Critical


I've met serious perfomance issue.
please see visualvm screenshot.

Here is hashCode implementation from the class:

{code}
 @Override
    public int hashCode() {
        int hash = 17;
        for (Iterator<Object> it = mFields.iterator(); it.hasNext();) {
            Object o = it.next();
            if (o != null) {
                hash = 31 * hash + o.hashCode();
            }
        }
        return hash;
    }
{code}

I don't see any reason here to iterate over the whole tuple, aggregate hash value and then return it.

I can fix it, if it's possible to take part in dev process. I'm new to it :(

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira