You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsuyoshi Ozawa (JIRA)" <ji...@apache.org> on 2015/07/15 18:03:05 UTC
[jira] [Commented] (HADOOP-10365) BufferedOutputStream in
FileUtil#unpackEntries() should be closed in finally block
[ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628285#comment-14628285 ]
Tsuyoshi Ozawa commented on HADOOP-10365:
-----------------------------------------
[~kiranmr] sorry for the delay. Can we remove explicit close of outputStream because we use try-with-resources statement?
{quote}
+ outputStream.close();
{quote}
> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-10365
> URL: https://issues.apache.org/jira/browse/HADOOP-10365
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Ted Yu
> Assignee: Kiran Kumar M R
> Priority: Minor
> Labels: BB2015-05-RFC
> Attachments: HADOOP-10365.2.patch, HADOOP-10365.3.patch, HADOOP-10365.4.patch, HADOOP-10365.5.patch, HADOOP-10365.patch
>
>
> {code}
> BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));
> ...
> outputStream.flush();
> outputStream.close();
> {code}
> outputStream should be closed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)