You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/02/26 12:21:13 UTC
[GitHub] [calcite] danny0405 commented on a change in pull request #1833:
[CALCITE-3828] MergeJoin throws NPE in case of null keys
danny0405 commented on a change in pull request #1833: [CALCITE-3828] MergeJoin throws NPE in case of null keys
URL: https://github.com/apache/calcite/pull/1833#discussion_r384457610
##########
File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -3829,6 +3829,12 @@ private boolean advance() {
TInner right = rightEnumerator.current();
TKey rightKey = innerKeySelector.apply(right);
for (;;) {
+ // mergeJoin assumes inputs sorted in ascending order with nulls last,
Review comment:
The nulls order is actually defined by the `RelFieldCollation`, did we set it anywhere ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services