You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/05 16:14:51 UTC
[GitHub] [commons-daemon] arturobernalg commented on a change in pull request #22: Minor Improvement:
arturobernalg commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571081927
##########
File path: src/main/java/org/apache/commons/daemon/support/DaemonWrapper.java
##########
@@ -40,12 +40,17 @@
private final static String STOP_CLASS = "stop";
private final static String STOP_METHOD = "stop.method";
private final static String STOP_ARGS = "stop.args";
- private String configFileName = null;
+ private String configFileName;
private final DaemonConfiguration config;
private final Invoker startup;
private final Invoker shutdown;
+ /**
+ * An empty immutable {@code String} array.
Review comment:
Changed
##########
File path: src/main/java/org/apache/commons/daemon/support/DaemonConfiguration.java
##########
@@ -62,6 +62,11 @@
private final Properties configurationProperties;
private final Properties systemProperties;
+ /**
+ * An empty immutable {@code String} array.
+ */
Review comment:
Changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org