You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2025/06/13 07:43:08 UTC
[PR] Add Hebrew translation for browse.json [airflow]
eladkal opened a new pull request, #51679:
URL: https://github.com/apache/airflow/pull/51679
cc @Dev-iL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Hebrew translation for browse.json [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on code in PR #51679:
URL: https://github.com/apache/airflow/pull/51679#discussion_r2145058099
##########
airflow-core/src/airflow/ui/src/i18n/locales/he/browse.json:
##########
@@ -0,0 +1,23 @@
+{
+ "auditLog": {
+ "actions": {
+ "collapseAllExtra": "כווץ את כל ה-JSON הנוסף",
Review Comment:
אני חושב שיש לזה מונח שונה, כי כיווץ בד"כ קשור לcompression
##########
airflow-core/src/airflow/ui/src/i18n/locales/he/browse.json:
##########
@@ -0,0 +1,23 @@
+{
+ "auditLog": {
+ "actions": {
+ "collapseAllExtra": "כווץ את כל ה-JSON הנוסף",
+ "expandAllExtra": "הרחב את כל ה-JSON הנוסף"
+ },
+ "columns": {
+ "event": "אירוע",
+ "extra": "נוסף",
Review Comment:
"extra" means something like "payload" in this context, no? If so, we should think about a more meaningful term imho.
(I don't have any suggestion at the moment since I didn't sleep too well, for obvious reasons)
##########
airflow-core/src/airflow/ui/src/i18n/locales/he/browse.json:
##########
@@ -0,0 +1,23 @@
+{
+ "auditLog": {
+ "actions": {
+ "collapseAllExtra": "כווץ את כל ה-JSON הנוסף",
+ "expandAllExtra": "הרחב את כל ה-JSON הנוסף"
+ },
+ "columns": {
+ "event": "אירוע",
+ "extra": "נוסף",
+ "user": "משתמש",
+ "when": "מתי"
+ },
+ "title": "יומן ביקורת"
Review Comment:
Is that the term we settled on in the main json?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Hebrew translation for browse.json [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #51679:
URL: https://github.com/apache/airflow/pull/51679#discussion_r2145527351
##########
airflow-core/src/airflow/ui/src/i18n/locales/he/browse.json:
##########
@@ -0,0 +1,23 @@
+{
+ "auditLog": {
+ "actions": {
+ "collapseAllExtra": "כווץ את כל ה-JSON הנוסף",
Review Comment:
i didn't find better wording, we can improve later if someone raise suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Hebrew translation for browse.json [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #51679:
URL: https://github.com/apache/airflow/pull/51679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org