[GitHub] [gobblin] aplex commented on a change in pull request #3228: [GOBBLIN-1389] Ensuring exception being propagated in Hive-Reg code path

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3228:
URL: https://github.com/apache/gobblin/pull/3228#discussion_r577918774



##########
File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -377,7 +378,7 @@ public Boolean call() throws Exception {
           }
         });
       } catch (ExecutionException ee) {
-        throw new IOException("Database existence checking throwing execution exception.");
+        throw new IOException("Database existence checking throwing execution exception.", ee);

Review comment:
       Do we know the typical reasons for the exception at this place, or it's hard to tell at this layer?
   Ideally, exception messages should be in the format of "Problem happened because of A, do B to resolve it".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org