You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/27 17:23:48 UTC

[GitHub] [beam] KevinGG opened a new pull request #12699: [BEAM-10775] Added a typescript precommit job

KevinGG opened a new pull request #12699:
URL: https://github.com/apache/beam/pull/12699


   1. The job runs 2 checks: jest for unit tests; eslint for lint and
      format.
   2. The job is triggered on change under
      sdks/python/apache_beam/runners/interactive/extensions. Any
      typescript code outside this directory needs to be explicitly added
      to the trigger pattern and the copyTsSource task.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website | Whitespace
   --- | --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   ![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg)
   ![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682994709






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682095681


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=h1) Report
   > Merging [#12699](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d5201cfb96ff4ac1299f8741a0f6cbdba2ac05ec?el=desc) will **increase** coverage by `4.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12699/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12699      +/-   ##
   ==========================================
   + Coverage   35.58%   40.30%   +4.72%     
   ==========================================
     Files          72      451     +379     
     Lines         874    53168   +52294     
   ==========================================
   + Hits          311    21429   +21118     
   - Misses        563    31739   +31176     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...eam/runners/dataflow/internal/clients/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL3Nka3MvcHl0aG9uLw==) | | |
   | [sdks/python/apache\_beam/runners/job/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9qb2Ivc2Rrcy9weXRob24v) | | |
   | [...pache\_beam/examples/complete/juliaset/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvc2Rrcy9weXRob24v) | | |
   | [.../python/apache\_beam/examples/snippets/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvc2Rrcy9weXRob24v) | | |
   | [sdks/python/apache\_beam/runners/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9zZGtzL3B5dGhvbi8=) | | |
   | [...apache\_beam/runners/dataflow/internal/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9zZGtzL3B5dGhvbi8=) | | |
   | [...pache\_beam/testing/benchmarks/nexmark/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvc2Rrcy9weXRob24v) | | |
   | [...beam/io/gcp/internal/clients/bigquery/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvc2Rrcy9weXRob24v) | | |
   | [...nners/interactive/testing/integration/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3Nka3MvcHl0aG9uLw==) | | |
   | [...python/apache\_beam/testing/benchmarks/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL3Nka3MvcHl0aG9uLw==) | | |
   | ... and [513 more](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=footer). Last update [faf76d5...024f1d6](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682224645


   Run Seed Job


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682095681


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=h1) Report
   > Merging [#12699](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d5201cfb96ff4ac1299f8741a0f6cbdba2ac05ec?el=desc) will **increase** coverage by `4.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12699/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12699      +/-   ##
   ==========================================
   + Coverage   35.58%   40.30%   +4.72%     
   ==========================================
     Files          72      451     +379     
     Lines         874    53168   +52294     
   ==========================================
   + Hits          311    21429   +21118     
   - Misses        563    31739   +31176     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/io/gcp/tests/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL3Rlc3RzL3Nka3MvcHl0aG9uLw==) | | |
   | [...ython/apache\_beam/runners/portability/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtzL3B5dGhvbi8=) | | |
   | [...eam/testing/benchmarks/nexmark/models/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL3Nka3MvcHl0aG9uLw==) | | |
   | [...nners/interactive/testing/integration/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3Nka3MvcHl0aG9uLw==) | | |
   | [sdks/python/apache\_beam/runners/job/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9qb2Ivc2Rrcy9weXRob24v) | | |
   | [...\_beam/testing/benchmarks/chicago\_taxi/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS9zZGtzL3B5dGhvbi8=) | | |
   | [sdks/python/apache\_beam/typehints/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3Nka3MvcHl0aG9uLw==) | | |
   | [.../python/apache\_beam/examples/cookbook/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svc2Rrcy9weXRob24v) | | |
   | [...ython/apache\_beam/io/gcp/experimental/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2V4cGVyaW1lbnRhbC9zZGtzL3B5dGhvbi8=) | | |
   | [...mples/snippets/transforms/aggregation/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9zZGtzL3B5dGhvbi8=) | | |
   | ... and [513 more](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=footer). Last update [faf76d5...024f1d6](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682095681


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=h1) Report
   > Merging [#12699](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d5201cfb96ff4ac1299f8741a0f6cbdba2ac05ec?el=desc) will **increase** coverage by `4.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12699/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12699      +/-   ##
   ==========================================
   + Coverage   35.58%   40.30%   +4.72%     
   ==========================================
     Files          72      451     +379     
     Lines         874    53168   +52294     
   ==========================================
   + Hits          311    21429   +21118     
   - Misses        563    31739   +31176     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/io/external/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc2Rrcy9weXRob24v) | | |
   | [sdks/python/apache\_beam/tools/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdG9vbHMvc2Rrcy9weXRob24v) | | |
   | [...he\_beam/runners/interactive/messaging/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9tZXNzYWdpbmcvc2Rrcy9weXRob24v) | | |
   | [...s/python/apache\_beam/runners/internal/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcm5hbC9zZGtzL3B5dGhvbi8=) | | |
   | [...nners/interactive/testing/integration/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3Nka3MvcHl0aG9uLw==) | | |
   | [...ache\_beam/runners/interactive/caching/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL3Nka3MvcHl0aG9uLw==) | | |
   | [...rs/dataflow/internal/clients/dataflow/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L3Nka3MvcHl0aG9uLw==) | | |
   | [sdks/python/apache\_beam/testing/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9zZGtzL3B5dGhvbi8=) | | |
   | [.../python/apache\_beam/examples/cookbook/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svc2Rrcy9weXRob24v) | | |
   | [sdks/python/apache\_beam/portability/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvc2Rrcy9weXRob24v) | | |
   | ... and [513 more](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=footer). Last update [faf76d5...024f1d6](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682106009


   R: @pabloem 
   
   PTAL, thx!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-683454024


   @KevinGG please add this PreCommit to the .test-infra/jenkins/README.md, as well as the Pull Request template so that we will keep it tracked


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #12699:
URL: https://github.com/apache/beam/pull/12699


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682095681


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=h1) Report
   > Merging [#12699](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d5201cfb96ff4ac1299f8741a0f6cbdba2ac05ec?el=desc) will **increase** coverage by `4.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12699/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12699      +/-   ##
   ==========================================
   + Coverage   35.58%   40.30%   +4.72%     
   ==========================================
     Files          72      451     +379     
     Lines         874    53168   +52294     
   ==========================================
   + Hits          311    21429   +21118     
   - Misses        563    31739   +31176     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...python/apache\_beam/testing/benchmarks/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL3Nka3MvcHl0aG9uLw==) | | |
   | [...ache\_beam/runners/interactive/options/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL3Nka3MvcHl0aG9uLw==) | | |
   | [...eam/runners/portability/fn\_api\_runner/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3Nka3MvcHl0aG9uLw==) | | |
   | [...ache\_beam/runners/interactive/testing/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3Nka3MvcHl0aG9uLw==) | | |
   | [...apache\_beam/runners/dataflow/internal/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9zZGtzL3B5dGhvbi8=) | | |
   | [...dks/python/apache\_beam/runners/worker/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2Rrcy9weXRob24v) | | |
   | [...beam/io/gcp/internal/clients/bigquery/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvc2Rrcy9weXRob24v) | | |
   | [...nners/interactive/testing/integration/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3Nka3MvcHl0aG9uLw==) | | |
   | [...on/apache\_beam/io/gcp/datastore/v1new/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9zZGtzL3B5dGhvbi8=) | | |
   | [...s/python/apache\_beam/runners/dataflow/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9zZGtzL3B5dGhvbi8=) | | |
   | ... and [513 more](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=footer). Last update [faf76d5...024f1d6](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682095681


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=h1) Report
   > Merging [#12699](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d5201cfb96ff4ac1299f8741a0f6cbdba2ac05ec?el=desc) will **increase** coverage by `4.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12699/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12699      +/-   ##
   ==========================================
   + Coverage   35.58%   40.30%   +4.72%     
   ==========================================
     Files          72      451     +379     
     Lines         874    53168   +52294     
   ==========================================
   + Hits          311    21429   +21118     
   - Misses        563    31739   +31176     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...pache\_beam/testing/benchmarks/nexmark/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvc2Rrcy9weXRob24v) | | |
   | [...am/testing/benchmarks/nexmark/queries/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9zZGtzL3B5dGhvbi8=) | | |
   | [...eam/runners/portability/fn\_api\_runner/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3Nka3MvcHl0aG9uLw==) | | |
   | [...nners/interactive/testing/integration/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL3Nka3MvcHl0aG9uLw==) | | |
   | [sdks/python/apache\_beam/utils/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2Rrcy9weXRob24v) | | |
   | [...apache\_beam/runners/dataflow/internal/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9zZGtzL3B5dGhvbi8=) | | |
   | [sdks/python/apache\_beam/io/external/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc2Rrcy9weXRob24v) | | |
   | [...sting/benchmarks/chicago\_taxi/trainer/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL3Nka3MvcHl0aG9uLw==) | | |
   | [sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24v) | | |
   | [...dks/python/apache\_beam/io/aws/clients/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvc2Rrcy9weXRob24v) | | |
   | ... and [513 more](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=footer). Last update [faf76d5...024f1d6](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KevinGG commented on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
KevinGG commented on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682906338


   Run Typescript PreCommit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-682095681


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=h1) Report
   > Merging [#12699](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/d5201cfb96ff4ac1299f8741a0f6cbdba2ac05ec?el=desc) will **increase** coverage by `4.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12699/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12699      +/-   ##
   ==========================================
   + Coverage   35.58%   40.30%   +4.72%     
   ==========================================
     Files          72      451     +379     
     Lines         874    53168   +52294     
   ==========================================
   + Hits          311    21429   +21118     
   - Misses        563    31739   +31176     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...eam/runners/portability/fn\_api\_runner/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3Nka3MvcHl0aG9uLw==) | | |
   | [sdks/python/apache\_beam/ml/gcp/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvZ2NwL3Nka3MvcHl0aG9uLw==) | | |
   | [...beam/io/gcp/internal/clients/bigquery/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvc2Rrcy9weXRob24v) | | |
   | [...n/apache\_beam/io/gcp/internal/clients/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2ludGVybmFsL2NsaWVudHMvc2Rrcy9weXRob24v) | | |
   | [...pache\_beam/runners/dataflow/native\_io/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9uYXRpdmVfaW8vc2Rrcy9weXRob24v) | | |
   | [sdks/python/apache\_beam/runners/job/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9qb2Ivc2Rrcy9weXRob24v) | | |
   | [...sting/benchmarks/chicago\_taxi/trainer/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL3Nka3MvcHl0aG9uLw==) | | |
   | [...ython/apache\_beam/runners/portability/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtzL3B5dGhvbi8=) | | |
   | [...rs/dataflow/internal/clients/dataflow/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L3Nka3MvcHl0aG9uLw==) | | |
   | [sdks/python/apache\_beam/io/sdks/python/](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc2Rrcy9weXRob24v) | | |
   | ... and [513 more](https://codecov.io/gh/apache/beam/pull/12699/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=footer). Last update [faf76d5...024f1d6](https://codecov.io/gh/apache/beam/pull/12699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #12699: [BEAM-10775] Added a typescript precommit job

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12699:
URL: https://github.com/apache/beam/pull/12699#issuecomment-683453912


   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org