[GitHub] sijie commented on a change in pull request #1758: Windowing for Pulsar Functions

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1758: Windowing for Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187249092
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -219,7 +225,16 @@ void processArguments() throws Exception {
         protected String userConfigString;
         @Parameter(names = "--parallelism", description = "The function's parallelism factor (i.e. the number of function instances to run)")
         protected String parallelism;
-
+        @Parameter(names = "--windowLengthCount", description = "")
 
 Review comment:
   nit: (not requesting any changes here, a in-depth discussion is required)
   
   I really don't think having the ability to override every settings in the command line is a sustainable solution. I think those settings should eventually be in the yaml file. otherwise we will keep adding new command line overrides when we have new features.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services