You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/18 11:32:31 UTC

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21098: [FLINK-29622][runtime][security] Start kerberos delegation token provider only if the user provided valid credentials

gaborgsomogyi opened a new pull request, #21098:
URL: https://github.com/apache/flink/pull/21098

   ## What is the purpose of the change
   
   Kerberos delegation token manager starts even if the user not provided valid credentials. This is simply wrong behavior.
   
   ## Brief change log
   
   Load kerberos delegation token manager only if the user provided valid credentials.
   
   ## Verifying this change
   
   * Executed `EventTimeWindowCheckpointingITCase` and double checked that exception is not thrown
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mbalassi merged pull request #21098: [FLINK-29622][runtime][security] Start kerberos delegation token provider only if the user provided valid credentials

Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #21098:
URL: https://github.com/apache/flink/pull/21098


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21098: [FLINK-29622][runtime][security] Start kerberos delegation token provider only if the user provided valid credentials

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21098:
URL: https://github.com/apache/flink/pull/21098#issuecomment-1282256923

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "83777cfeb0ea902a1a5f51665c6f9358ededcbbf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "83777cfeb0ea902a1a5f51665c6f9358ededcbbf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 83777cfeb0ea902a1a5f51665c6f9358ededcbbf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #21098: [FLINK-29622][runtime][security] Start kerberos delegation token provider only if the user provided valid credentials

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21098:
URL: https://github.com/apache/flink/pull/21098#issuecomment-1282518932

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mbalassi commented on pull request #21098: [FLINK-29622][runtime][security] Start kerberos delegation token provider only if the user provided valid credentials

Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #21098:
URL: https://github.com/apache/flink/pull/21098#issuecomment-1283987953

   Thanks @gaborgsomogyi. I have verified this change via running multiple ITCases and they do not show the stacktrace that was reported previously.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #21098: [FLINK-29622][runtime][security] Start kerberos delegation token provider only if the user provided valid credentials

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21098:
URL: https://github.com/apache/flink/pull/21098#issuecomment-1282250349

   cc @gyfora @mbalassi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #21098: [FLINK-29622][runtime][security] Start kerberos delegation token provider only if the user provided valid credentials

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21098:
URL: https://github.com/apache/flink/pull/21098#issuecomment-1282399937

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org