[GitHub] [incubator-echarts] pissang edited a comment on pull request #12775: Custom series enhancement (for-next)

[GitBox <gi...@apache.org>]

pissang edited a comment on pull request #12775:
URL: https://github.com/apache/incubator-echarts/pull/12775#issuecomment-647291692


   >    // currently only transform props  
       // (x, y, scaleX, scaleY, originX, orignY, rotation) 
       // are available here. Other attributes are not supported 
       // until really needed one day.
       setAttr(key: TransformProps, val: unknown): void;
       getAttr(key: TransformProps): unknown;
   
   I will prefer `setTransform`, `getTransform` over `setAttr`, `getAttr` here.
   
   Also, can parameter be an object? In the case want to update multiple multiple transform properties:
   
   ```js
   setTransform({ x: Math.sin(angle), y: Math.cos(angle), rotation: angle });
   ```
   
   It will be simpler than:
   ```js
   setTransform('x', Math.sin(angle));
   setTransform('y', Math.cos(angle));
   setTransform('rotation', angle);
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org