[GitHub] [hbase] YutSean commented on a change in pull request #3968: HBASE-26613 The logic of the method incrementIV in Encryption class has problem

[GitBox <gi...@apache.org>]

YutSean commented on a change in pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#discussion_r772795251



##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java
##########
@@ -640,20 +640,17 @@ public static void incrementIv(byte[] iv) {
   }
 
   public static void incrementIv(byte[] iv, int v) {
+    // v should be > 0
     int length = iv.length;
-    boolean carry = true;
-    // TODO: Optimize for v > 1, e.g. 16, 32
-    do {
-      for (int i = 0; i < length; i++) {
-        if (carry) {
-          iv[i] = (byte) ((iv[i] + 1) & 0xFF);
-          carry = 0 == iv[i];
-        } else {
-          break;
-        }
+    int sum = 0;
+    for (int i = 0; i < length; i++) {
+      if (v <= 0) {
+        break;
       }
-      v--;
-    } while (v > 0);
+      sum = v + iv[i];

Review comment:
       Right, we should care the negative here. Has refined the logic here and added negative UT cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org