You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/03/15 09:46:49 UTC
[Impala-ASF-CR] IMPALA-11182: catch exceptions of orc::RowReader::createRowBatch
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18321
to look at the new patch set (#2).
Change subject: IMPALA-11182: catch exceptions of orc::RowReader::createRowBatch
......................................................................
IMPALA-11182: catch exceptions of orc::RowReader::createRowBatch
The ORC lib uses exceptions to report failures. We are missing
exception handling in invoking orc::RowReader::createRowBatch which
requires memory allocation and could raise exceptions when it fails.
This patch simply adds a catch clause for it.
To simplify the codes, a macro is added for catching the ORC exceptions
with given message and an additional statement.
Tests:
- TODO: run test_scanner_fuzz.py 100 times
Change-Id: I76e36a238220e7bed1cbbdcb3fc7d35394bfa023
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 32 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/18321/2
--
To view, visit http://gerrit.cloudera.org:8080/18321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76e36a238220e7bed1cbbdcb3fc7d35394bfa023
Gerrit-Change-Number: 18321
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>