[PATCH] "make clean" bombs if no subdirectory modules are used

["Roy T. Fielding" <fi...@kiwi.ICS.UCI.EDU>]

The following patch is necessary in order for "make clean" to work
when there are no subdirectory modules selected within Configuration.

.....Roy

Index: Configure
===================================================================
RCS file: /export/home/cvs/apache/src/Configure,v
retrieving revision 1.82
diff -c -r1.82 Configure
*** Configure	1997/03/18 10:23:53	1.82
--- Configure	1997/03/20 16:14:27
***************
*** 590,609 ****
  
  awk >> modules/Makefile < $tmpfile '\
     BEGIN {printf "MODULES="} \
!    ($3 ~ /modules\//) {split ($3, pp, "/"); printf "%s ", pp[2]} \
     END {printf "\n"}'
  cat << EOF >> modules/Makefile
  
! default:
! 	(for dir in \$(MODULES); do \\
! 		cd \$\$dir; \\
! 		\$(MAKE) CC=\$(CC) AUX_CFLAGS='\$(MOD_CFLAGS)' RANLIB='\$(RANLIB)'; \\
! 		cd ..; \\
! 	done)
! 
! clean:	
! 	(for dir in \$(MODULES); do \\
! 		cd \$\$dir; \$(MAKE) clean; \\
! 		cd ..; \\
! 	done)
  EOF
--- 590,614 ----
  
  awk >> modules/Makefile < $tmpfile '\
     BEGIN {printf "MODULES="} \
!    ($3 ~ /modules\//) {split ($3, pp, "/"); printf "%s.build ", pp[2]} \
     END {printf "\n"}'
+ 
+ awk >> modules/Makefile < $tmpfile '\
+    BEGIN {printf "CLEANERS="} \
+    ($3 ~ /modules\//) {split ($3, pp, "/"); printf "%s.clean ", pp[2]} \
+    END {printf "\n"}'
+ 
  cat << EOF >> modules/Makefile
  
! default: \$(MODULES)
! 	@echo "done building module subdirectories"
! 
! clean: \$(CLEANERS)
! 	@echo "done cleaning module subdirectories"
! 
! %.build:
! 	(cd \$*; \$(MAKE) CC=\$(CC) AUX_CFLAGS='\$(MOD_CFLAGS)' RANLIB='\$(RANLIB)')
! 
! %.clean:
! 	(cd \$*; \$(MAKE) clean)
  EOF

Re: [PATCH] "make clean" bombs if no subdirectory modules are used

[Chuck Murcko <ch...@topsail.org>]

Roy T. Fielding wrote:
> 
> The following patch is necessary in order for "make clean" to work
> when there are no subdirectory modules selected within Configuration.
> 
> .....Roy
> 
Uh, change that to -1. This seems to break builds and cleans when the
proxy *is* defined:

(cd modules;  make CC=gcc AUX_CFLAGS='-g -Wall -DSTATUS
-Dconnect=Rconnect -Dselect=Rselect -Dgethostbyname=Rgethostbyname '
RANLIB='ranlib')
make: don't know how to make proxy.build. Stop
*** Error code 2

Stop.

Roy, what errors do you get when you don't have any subdirectory modules
selected? I don't see this on the platforms here (I'll doublecheck on
Solaris tomorrow).
-- 
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org

Re: [PATCH] "make clean" bombs if no subdirectory modules are used

[Chuck Murcko <ch...@topsail.org>]

+1.

 Roy T. Fielding wrote:
> 
> The following patch is necessary in order for "make clean" to work
> when there are no subdirectory modules selected within Configuration.
> 
> .....Roy
> 

-- 
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org