[GitHub] jon-wei commented on a change in pull request #6757: Set is_available to false by default for published segment

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #6757: Set is_available to false by default for published segment
URL: https://github.com/apache/incubator-druid/pull/6757#discussion_r242776724
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java
 ##########
 @@ -330,10 +330,10 @@ public void testGetTableMap()
   public void testSegmentsTable() throws Exception
   {
     // total segments = 6
-    // segments 1,2,3 are published and available
-    // segments 4,5,6  are published but unavailable
-    // segment 3 is published but not served
-    // segment 2 is served by 2 servers, so num_replicas=2
+    // segments 1,2,3 are published but unavailable
+    // segments 4,5,6  are published and available
 
 Review comment:
   The "test1", "test2", and "test3" segments should also be contained in the metadata response that's returned by `EasyMock.expect(client.goAsync(request, responseHandler)).andReturn(future).once();`.
   
   They're currently "published" in this test implicitly by being served from a historical in TestServerInventoryView, but in a real scenario they would also appear in the metadata storage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org