You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/08/29 07:12:37 UTC
[jira] [Created] (HBASE-4272) Add hbck feature to only inspect and
try to repair META and ROOT
Add hbck feature to only inspect and try to repair META and ROOT
----------------------------------------------------------------
Key: HBASE-4272
URL: https://issues.apache.org/jira/browse/HBASE-4272
Project: HBase
Issue Type: Improvement
Affects Versions: 0.92.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4272) Add hbck feature to only inspect
and try to repair META and ROOT
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103355#comment-13103355 ]
Hudson commented on HBASE-4272:
-------------------------------
Integrated in HBase-TRUNK #2202 (See [https://builds.apache.org/job/HBase-TRUNK/2202/])
HBASE-4272. Add -metaonly flag to hbck feature to only inspect and try to repair META and ROOT.
todd :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.92.0, 0.90.5
>
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch, hbase-4272.txt
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4272) Add hbck feature to only inspect and
try to repair META and ROOT
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HBASE-4272:
-------------------------------
Attachment: 0010-HBASE-4272.-fsck-meta-only-mode.patch
Here's a patch which adds -checkmeta flag to hbck, which will cause it to ignore user tables for a run. This makes it run much faster, and can deal with the case when META is unassigned.
It still doesn't deal properly when ROOT is stuck unassigned. That should be improved.
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4272) Add hbck feature to only inspect and
try to repair META and ROOT
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HBASE-4272.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.90.5
0.92.0
Hadoop Flags: [Reviewed]
I committed to 0.90.5 as well as trunk, since it's just an hbck change and pretty trivial. Thanks for reviewing, Ted.
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.92.0, 0.90.5
>
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch, hbase-4272.txt
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4272) Add hbck feature to only inspect
and try to repair META and ROOT
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093413#comment-13093413 ]
Ted Yu commented on HBASE-4272:
-------------------------------
In filterOnlyMetaRegions():
{code}
+ if (hri.isMetaRegion()) {
+ ret.add(hri);
+ }
{code}
Here only .META. region is included. This is inconsistent with:
{code}
+ if (!checkMetaOnly ||
+ dirName.equals("-ROOT-") ||
+ dirName.equals(".META.")) {
+ tableDirs.add(file);
+ }
{code}
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4272) Add hbck feature to only inspect
and try to repair META and ROOT
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103242#comment-13103242 ]
Ted Yu commented on HBASE-4272:
-------------------------------
+1 on patch version 2.
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch, hbase-4272.txt
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4272) Add hbck feature to only inspect
and try to repair META and ROOT
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093410#comment-13093410 ]
stack commented on HBASE-4272:
------------------------------
+1
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4272) Add hbck feature to only inspect
and try to repair META and ROOT
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093415#comment-13093415 ]
Ted Yu commented on HBASE-4272:
-------------------------------
{code}
+ } else if (cmd.equals("-checkmeta")) {
+ fsck.setCheckMetaOnly();
{code}
Probably -checkmetaonly is a better option name ?
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4272) Add hbck feature to only inspect and
try to repair META and ROOT
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HBASE-4272:
-------------------------------
Attachment: hbase-4272.txt
New patch addresses Ted's comments
> Add hbck feature to only inspect and try to repair META and ROOT
> ----------------------------------------------------------------
>
> Key: HBASE-4272
> URL: https://issues.apache.org/jira/browse/HBASE-4272
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: 0010-HBASE-4272.-fsck-meta-only-mode.patch, hbase-4272.txt
>
>
> In cases that META is stuck unassigned, hbck currently crashes. It should be able to handle mis-deployed META and ROOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira