[jira] Commented: (VELOCITY-227) ResourceFactory not extensible

["Will Glass-Husain (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/VELOCITY-227?page=comments#action_12447368 ] 
            
Will Glass-Husain commented on VELOCITY-227:
--------------------------------------------

Since you can choose the implementation via velocity.properties, wouldn't this fall under a prohibited 'not-backwards-compatible'  change?

> ResourceFactory not extensible
> ------------------------------
>
>                 Key: VELOCITY-227
>                 URL: http://issues.apache.org/jira/browse/VELOCITY-227
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: 1.5
>         Environment: Operating System: All
> Platform: All
>            Reporter: Charles Morehead
>            Priority: Minor
>
> The class org.apache.velocity.runtime.resource.ResourceFactory provides
> no mechanism for allowing sub-classes of Template or ContentResources
> to be returned.
> Since ResourceManagerImpl makes a call to ResourceFactory.getResource(),
> the only way to override the behavior is to subclass ResourceManagerImpl
> and cut-paste-then-modify the code for loadResource().
> At the very least, moving the ResourceFactory.getResource() call into
> a separate, protected method in ResourceManagerImpl would greatly simplify
> sub-classing Templates and/or ContentResources.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org