You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/20 18:16:00 UTC
[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull
request #3993: In TableConfig, add checks for mandatory fields
sunithabeeram commented on a change in pull request #3993: In TableConfig, add checks for mandatory fields
URL: https://github.com/apache/incubator-pinot/pull/3993#discussion_r267479988
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
##########
@@ -118,14 +118,24 @@ public static TableConfig fromJsonString(String jsonString)
@Nonnull
public static TableConfig fromJSONConfig(@Nonnull JsonNode jsonConfig)
throws IOException {
+ // Mandatory fields
+ Preconditions.checkState(jsonConfig.has(TABLE_TYPE_KEY), "Table type is missing");
TableType tableType = TableType.valueOf(jsonConfig.get(TABLE_TYPE_KEY).asText().toUpperCase());
+ Preconditions.checkState(jsonConfig.has(TABLE_NAME_KEY), "Table name is missing");
String tableName = TableNameBuilder.forType(tableType).tableNameWithType(jsonConfig.get(TABLE_NAME_KEY).asText());
-
+ Preconditions
+ .checkState(jsonConfig.has(VALIDATION_CONFIG_KEY), "Mandatory config '%s' is missing", VALIDATION_CONFIG_KEY);
SegmentsValidationAndRetentionConfig validationConfig =
extractChildConfig(jsonConfig, VALIDATION_CONFIG_KEY, SegmentsValidationAndRetentionConfig.class);
+ Preconditions.checkState(jsonConfig.has(TENANT_CONFIG_KEY), "Mandatory config '%s' is missing", TENANT_CONFIG_KEY);
TenantConfig tenantConfig = extractChildConfig(jsonConfig, TENANT_CONFIG_KEY, TenantConfig.class);
+ Preconditions
+ .checkState(jsonConfig.has(INDEXING_CONFIG_KEY), "Mandatory config '%s' is missing", INDEXING_CONFIG_KEY);
Review comment:
Are INDEXING and CUSTOM configs really mandatory?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org