[jira] [Commented] (SAMZA-1261) Flaky test: TestProcessJob testProcessJobKillShouldWork

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449007#comment-16449007 ] 

ASF GitHub Bot commented on SAMZA-1261:
---------------------------------------

GitHub user ahmedahamid opened a pull request:

    https://github.com/apache/samza/pull/485

    SAMZA-1261: Fix TestProcessJob flaky test

    Fix flaky test TestProcessJob testProcessJobKillShouldWork which was failing due to thread timing issues that were causing the test to fail intermittently. Also refactored ProcessJob to make it less prone to similar issues and added more unit tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahmedahamid/samza master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #485
    
----
commit e929ded34412d6f6ef45aef5a58e5eaff53f0927
Author: Ahmed Abdul Hamid <ah...@...>
Date:   2018-04-23T22:46:41Z

    SAMZA-1261: Fix TestProcessJob flaky test.

----


> Flaky test: TestProcessJob testProcessJobKillShouldWork
> -------------------------------------------------------
>
>                 Key: SAMZA-1261
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1261
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Prateek Maheshwari
>            Priority: Major
>
> {code}
> :samza-core_2.11:test
> testProcessJobKillShouldWork FAILED
>     java.lang.AssertionError: 
>         at org.junit.Assert.fail(Assert.java:91)
>         at org.junit.Assert.assertTrue(Assert.java:43)
>         at org.junit.Assert.assertTrue(Assert.java:54)
>         at org.apache.samza.job.local.TestProcessJob.testProcessJobKillShouldWork(TestProcessJob.scala:54)
> 470 tests completed, 1 failed, 1 skipped
> :samza-core_2.11:test FAILED
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)