You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Taher Alkhateeb <sl...@gmail.com> on 2018/03/22 09:32:24 UTC
Re: svn commit: r1827470 - /ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
Just a note to all the documentation team, I think we should probably
delete most README files anyway. The manual should be comprehensive
and incorporate whatever is documented in these README files
On Thu, Mar 22, 2018 at 11:54 AM, <pg...@apache.org> wrote:
> Author: pgil
> Date: Thu Mar 22 08:54:00 2018
> New Revision: 1827470
>
> URL: http://svn.apache.org/viewvc?rev=1827470&view=rev
> Log:
> Fixed: Convert README.md to README.adoc.
> (OFBIZ-10272)
>
> Complete Jacques Fix, replacing all README.md occurence with README.adoc.
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy?rev=1827470&r1=1827469&r2=1827470&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy Thu Mar 22 08:54:00 2018
> @@ -26,15 +26,15 @@ import org.apache.ofbiz.testtools.Groovy
> class FileUtilTests extends GroovyScriptTestCase {
>
> /**
> - * Test FileUtil zipFileStream and unzipFileToFolder methods, using README.md
> + * Test FileUtil zipFileStream and unzipFileToFolder methods, using README.adoc
> */
> void testZipReadme() {
> String zipFilePath = UtilProperties.getPropertyValue("general", "http.upload.tmprepository", "runtime/tmp")
> - String zipName = 'README.md.zip'
> + String zipName = 'README.adoc.zip'
> String fileName = 'README.adoc'
> File originalReadme = new File(fileName)
>
> - //validate zipStream from README.md is not null
> + //validate zipStream from README.adoc is not null
> def zipStream = FileUtil.zipFileStream(originalReadme.newInputStream(), fileName)
> assert zipStream
>
> @@ -52,7 +52,7 @@ class FileUtilTests extends GroovyScript
> out.close()
> zipStream.close()
>
> - //ensure no README.md exist in tmp folder
> + //ensure no README.adoc exist in tmp folder
> File readme = new File(zipFilePath, fileName)
> if (readme.exists()) readme.delete()
>
>
>
Re: svn commit: r1827470 -
/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests
.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
I guess you mean replace by .adoc files?
Jacques
Le 22/03/2018 à 10:32, Taher Alkhateeb a écrit :
> Just a note to all the documentation team, I think we should probably
> delete most README files anyway. The manual should be comprehensive
> and incorporate whatever is documented in these README files
>
> On Thu, Mar 22, 2018 at 11:54 AM, <pg...@apache.org> wrote:
>> Author: pgil
>> Date: Thu Mar 22 08:54:00 2018
>> New Revision: 1827470
>>
>> URL: http://svn.apache.org/viewvc?rev=1827470&view=rev
>> Log:
>> Fixed: Convert README.md to README.adoc.
>> (OFBIZ-10272)
>>
>> Complete Jacques Fix, replacing all README.md occurence with README.adoc.
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
>>
>> Modified: ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy?rev=1827470&r1=1827469&r2=1827470&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy (original)
>> +++ ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy Thu Mar 22 08:54:00 2018
>> @@ -26,15 +26,15 @@ import org.apache.ofbiz.testtools.Groovy
>> class FileUtilTests extends GroovyScriptTestCase {
>>
>> /**
>> - * Test FileUtil zipFileStream and unzipFileToFolder methods, using README.md
>> + * Test FileUtil zipFileStream and unzipFileToFolder methods, using README.adoc
>> */
>> void testZipReadme() {
>> String zipFilePath = UtilProperties.getPropertyValue("general", "http.upload.tmprepository", "runtime/tmp")
>> - String zipName = 'README.md.zip'
>> + String zipName = 'README.adoc.zip'
>> String fileName = 'README.adoc'
>> File originalReadme = new File(fileName)
>>
>> - //validate zipStream from README.md is not null
>> + //validate zipStream from README.adoc is not null
>> def zipStream = FileUtil.zipFileStream(originalReadme.newInputStream(), fileName)
>> assert zipStream
>>
>> @@ -52,7 +52,7 @@ class FileUtilTests extends GroovyScript
>> out.close()
>> zipStream.close()
>>
>> - //ensure no README.md exist in tmp folder
>> + //ensure no README.adoc exist in tmp folder
>> File readme = new File(zipFilePath, fileName)
>> if (readme.exists()) readme.delete()
>>
>>
>>