You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2026/10/22 13:56:28 UTC
[PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
DaanHoogland opened a new pull request, #14467:
URL: https://github.com/apache/cloudstack/pull/14467
### Description
Declares a `ConfigKey` for every remaining entry of the deprecated `Config` enum and registers each one in its owner's `getConfigKeys()`. The enum entries stay in place and no call site changes; the only runtime effect is that the keys are registered with the ConfigDepot at startup. The follow-up PRs switch the call sites and the last one deletes the enum entries.
Also registers three keys that #13884 moved without registering (`default.page.size`, `check.pod.cidrs`, `cluster.message.timeout.seconds`). That omission is why #13884 failed the simulator CI: `updateConfiguration default.page.size` returned "doesn't exist".
Part 1 of 12 of the split of #13884 (phase out the deprecated `Config` enum, #10752). Base: `main`. Every other PR of the split builds on this one.
Size: 78 files, +1085/-42.
Split overview: foundation β parallel PRs (account, vpn-vpc, snapshot-usage, event-bus, literals) + stacked core-1 β¦ core-5 β enum-removal (last).
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.
π€ Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
github-actions[bot] commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6950321643
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6442199290
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14467) **Quality Gate passed**
Issues
 [39 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=14467&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=14467&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=14467&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [49.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14467&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14467&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14467)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6342726375
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/14467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.70%. Comparing base ([`c76c01e`](https://app.codecov.io/gh/apache/cloudstack/commit/c76c01e21a1d98fbdcb5da051d7336838873eeb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d58e94b`](https://app.codecov.io/gh/apache/cloudstack/commit/d58e94ba04dea7c0d05bfc0753ac7316531326a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (c76c01e) and HEAD (d58e94b). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (c76c01e) | HEAD (d58e94b) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #14467 +/- ##
=============================================
- Coverage 20.45% 3.70% -16.75%
=============================================
Files 6487 493 -5994
Lines 589329 42558 -546771
Branches 72246 8063 -64183
=============================================
- Hits 120554 1578 -118976
+ Misses 455642 40751 -414891
+ Partials 13133 229 -12904
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/14467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/14467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.70% <ΓΈ> (ΓΈ)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/14467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/14467?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6349369852
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
github-actions[bot] commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6802625324
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6345907296
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6347418974
Packaging result [SF]: βοΈ el8 βοΈ el9 βοΈ el10 βοΈ debian βοΈ suse15. SL-JID 19690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6345936404
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6349386896
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6376441625
<b>[SF] Trillian test result (tid-17220)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 58538 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14467-t17220-kvm-ol8.zip
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6464847166
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14467) **Quality Gate passed**
Issues
 [39 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=14467&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=14467&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=14467&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [49.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14467&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14467&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14467)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#discussion_r4361104043
##########
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java:
##########
@@ -138,6 +138,23 @@ public interface NetworkOrchestrationService {
ConfigKey<Integer> VmNetworkThrottlingRate = new ConfigKey<Integer>("Network", Integer.class, "vm.network.throttling.rate", "200",
"Default data transfer rate in megabits per second allowed in User vm's default network.", true, ConfigKey.Scope.Zone);
+ ConfigKey<String> NetworkLBHaproxyStatsVisibility = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.visibility", "global",
+ "Load Balancer(haproxy) stats visibility, the value can be one of the following six parameters : global,guest-network,link-local,disabled,all,default",
+ true, ConfigKey.Kind.Select, "global,guest-network,link-local,disabled,all,default");
+
+ ConfigKey<String> NetworkLBHaproxyStatsUri = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.uri", "/admin?stats",
+ "Load Balancer(haproxy) uri.", true);
+
+ ConfigKey<String> NetworkLBHaproxyStatsAuth = new ConfigKey<>("Secure", String.class,
+ "network.loadbalancer.haproxy.stats.auth", "admin1:AdMiN123",
+ "Load Balancer(haproxy) authentication string in the format username:password", true);
Review Comment:
This introduces a hard-coded default credential (\"admin1:AdMiN123\") for HAProxy stats auth. Even if marked as `Secure`, shipping a known default password is unsafe; consider using a null/empty default that disables auth until explicitly configured, or generating a random secret at first startup and persisting it (similar to other one-time generated secrets).
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/manager/BaremetalManager.java:
##########
@@ -21,11 +21,30 @@
import com.cloud.utils.component.Manager;
import com.cloud.utils.component.PluggableService;
import org.apache.cloudstack.api.BaremetalProvisionDoneNotificationCmd;
+import org.apache.cloudstack.framework.config.ConfigKey;
public interface BaremetalManager extends Manager, PluggableService {
public static final String EchoSecurityGroupAgent = "EchoSecurityGroupAgent";
public static final String ExternalBaremetalSystemUrl = "ExternalBaremetalSystemUrl";
public static final String DO_PXE = "doPxe";
+ ConfigKey<String> BaremetalInternalStorageServer = new ConfigKey<>("Advanced", String.class, "baremetal.internal.storage.server.ip", null,
+ "the ip address of server that stores kickstart file, kernel, initrd, ISO for advanced networking baremetal provisioning", true);
+
+ ConfigKey<Integer> BaremetalProvisionDoneNotificationTimeout = new ConfigKey<>("Advanced", Integer.class, "baremetal.provision.done.notification.timeout", "1800",
+ "the max time to wait before treating a baremetal provision as failure if no provision done notification is not received, in secs", true);
+
+ ConfigKey<String> ExternalBaremetalResourceClassName = new ConfigKey<>("Advanced", String.class, "external.baremetal.resource.classname", null,
+ "class name for handling external baremetal resource", true);
+
+ ConfigKey<Boolean> EnableBaremetalSecurityGroupAgentEcho = new ConfigKey<>("Advanced", Boolean.class, "enable.baremetal.securitygroup.agent.echo", "false",
+ "After starting provision process, periodcially echo security agent installed in the template. Treat provisioning as success only if echo successfully", true);
Review Comment:
Correct typo in config description: \"periodcially\" β \"periodically\".
##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -172,6 +175,22 @@ public interface StorageManager extends StorageService {
ConfigKey<Integer> MaxDataMigrationWaitTime = new ConfigKey<>("Advanced", Integer.class, "max.data.migration.wait.time", "15",
"Maximum wait time (in minutes) for a data migration task before spawning a new SSVM", false, ConfigKey.Scope.Global);
+
+ ConfigKey<Integer> VmDiskThrottlingIopsReadRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.iops_read_rate", "0",
+ "Default disk I/O read rate in requests per second allowed in User vm's disk.", true);
+
+ ConfigKey<Integer> VmDiskThrottlingIopsWriteRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.iops_write_rate", "0",
+ "Default disk I/O writerate in requests per second allowed in User vm's disk.", true);
+
+ ConfigKey<Long> VmDiskThrottlingBytesReadRate = new ConfigKey<>("Advanced", Long.class, "vm.disk.throttling.bytes_read_rate", "0",
+ "Default disk I/O read rate in bytes per second allowed in User vm's disk.", true);
+
+ ConfigKey<Long> VmDiskThrottlingBytesWriteRate = new ConfigKey<>("Advanced", Long.class, "vm.disk.throttling.bytes_write_rate", "0",
+ "Default disk I/O writerate in bytes per second allowed in User vm's disk.", true);
Review Comment:
Config description has a typo/wording issue: \"writerate\" should be \"write rate\".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#discussion_r4349403743
##########
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java:
##########
@@ -138,6 +138,23 @@ public interface NetworkOrchestrationService {
ConfigKey<Integer> VmNetworkThrottlingRate = new ConfigKey<Integer>("Network", Integer.class, "vm.network.throttling.rate", "200",
"Default data transfer rate in megabits per second allowed in User vm's default network.", true, ConfigKey.Scope.Zone);
+ ConfigKey<String> NetworkLBHaproxyStatsVisbility = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.visibility", "global",
+ "Load Balancer(haproxy) stats visibility, the value can be one of the following six parameters : global,guest-network,link-local,disabled,all,default",
+ true, ConfigKey.Kind.Select, "global,guest-network,link-local,disabled,all,default");
+
+ ConfigKey<String> NetworkLBHaproxyStatsUri = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.uri", "/admin?stats",
+ "Load Balancer(haproxy) uri.", true);
+
+ ConfigKey<String> NetworkLBHaproxyStatsAuth = new ConfigKey<>("Secure", String.class,
+ "network.loadbalancer.haproxy.stats.auth", "admin1:AdMiN123",
+ "Load Balancer(haproxy) authentication string in the format username:password", true);
Review Comment:
This introduces a hard-coded default credential (`admin1:AdMiN123`) for a security-sensitive setting. Even though the key is in the `Secure` category, a known default credential is unsafe and can lead to exposed HAProxy stats endpoints on fresh installs. Recommended: default this to `null`/empty (disabled unless explicitly configured), or generate/store a unique secret during installation/startup, and ensure the stats feature is off unless explicitly enabled.
##########
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java:
##########
@@ -138,6 +138,23 @@ public interface NetworkOrchestrationService {
ConfigKey<Integer> VmNetworkThrottlingRate = new ConfigKey<Integer>("Network", Integer.class, "vm.network.throttling.rate", "200",
"Default data transfer rate in megabits per second allowed in User vm's default network.", true, ConfigKey.Scope.Zone);
+ ConfigKey<String> NetworkLBHaproxyStatsVisbility = new ConfigKey<>("Network", String.class,
Review Comment:
The constant name `NetworkLBHaproxyStatsVisbility` is misspelled (should be `Visibility`). Since this is a newly introduced public constant, itβs best to correct it now to avoid propagating the typo across the codebase.
##########
engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java:
##########
@@ -33,6 +33,9 @@ public interface VMSnapshotManager extends VMSnapshotService, Manager {
ConfigKey<Integer> VMSnapshotMax = new ConfigKey<Integer>("Advanced", Integer.class, "vmsnapshot.max", "10", "Maximum VM snapshots for a single VM", true, ConfigKey.Scope.Account);
+ ConfigKey<Integer> VMSnapshotCreateWait = new ConfigKey<>("Advanced", Integer.class, "vmsnapshot.create.wait", "1800",
+ "In second, timeout for create vm snapshot", true);
Review Comment:
The description is grammatically incorrect and ambiguous. Suggest updating it to something like: βTimeout (in seconds) for VM snapshot creation.β (Same phrasing issue appears on several newly introduced timeout-related `ConfigKey` descriptions in this PR.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6442203566
<!-- coverage-grade-bot -->
## π΄ Test Coverage Grade: `D` β Marginal
| Metric | Value |
|--------|-------|
| Line coverage | **25.80%** |
| Branch coverage | **20.07%** |
### Grade Scale
| Grade | Line Coverage | Meaning |
|-------|--------------|---------|
| π’ A | β₯ 80% | Excellent - this code sleeps well at night π΄ |
| π‘ B | 60-79% | Good - almost there, don't stop now π |
| π C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags π¬ |
| π΄ D | 20-39% | Marginal - boldly shipping where no test has gone before π |
| β F | < 20% | Failing - tests? what tests? π₯ |
> Branch coverage is shown as a secondary signal. Grade is determined by **line coverage**.
> [View full Actions run](https://github.com/apache/cloudstack/actions/runs/40497436765)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] declare and register ConfigKeys for all remaining Config enum entries [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub) via commits" <co...@cloudstack.apache.org>.
sonarqubecloud[bot] commented on PR #14467:
URL: https://github.com/apache/cloudstack/pull/14467#issuecomment-6861366420
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14467) **Quality Gate passed**
Issues
 [39 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=14467&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=14467&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=14467&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [49.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14467&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14467&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14467)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org