You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/17 13:51:42 UTC

[GitHub] [pulsar-helm-chart] rvashishth commented on a change in pull request #41: Fix wrong variable reference in Grafana & Pulsar Manager port

rvashishth commented on a change in pull request #41:
URL: https://github.com/apache/pulsar-helm-chart/pull/41#discussion_r456455680



##########
File path: charts/pulsar/templates/pulsar-manager-deployment.yaml
##########
@@ -58,7 +58,7 @@ spec:
 {{ toYaml .Values.pulsar_manager.resources | indent 12 }}
         {{- end }}
           ports:
-          - containerPort: {{ .Values.pulsar_manager.port }}
+          - containerPort: {{ .Values.pulsar_manager.service.port }}

Review comment:
       I assume we should use `targetPort` here, as the `targetPort` under service is for pods. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org