Re: [PR] fix(XCom): /xcom/list got exception when applying filter on the value column [airflow]

["Lee-W (via GitHub)" <gi...@apache.org>]

Lee-W commented on code in PR #46053:
URL: https://github.com/apache/airflow/pull/46053#discussion_r1938902194


##########
airflow/www/utils.py:
##########
@@ -779,6 +779,80 @@ class UtcAwareFilterConverter(fab_sqlafilters.SQLAFilterConverter):
     """Retrieve conversion tables for UTC-Aware filters."""
 
 
+class XComFilterStartsWith(fab_sqlafilters.FilterStartsWith):
+    """Starts With filter for XCom values."""
+
+    def apply(self, query, value):
+        query, field = get_field_setup_query(query, self.model, self.column_name)

Review Comment:
   The code here looks similar to others in the `apply` method. We probably could add a function to reduce code duplication. Also it would be nice if we could add type annotation. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org