You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2008/09/04 12:11:44 UTC
[jira] Created: (LUCENE-1376) sometimes if a BG merge hits an
exception, optimize() will fail to forward the exception
sometimes if a BG merge hits an exception, optimize() will fail to forward the exception
----------------------------------------------------------------------------------------
Key: LUCENE-1376
URL: https://issues.apache.org/jira/browse/LUCENE-1376
Project: Lucene - Java
Issue Type: Bug
Components: Index
Affects Versions: 2.3
Reporter: Michael McCandless
Assignee: Michael McCandless
Priority: Trivial
Fix For: 2.4
Attachments: LUCENE-1376.patch
I was seeing an intermittant failure, only on a Windows instance running inside VMWare, of TestIndexWriter.testAddIndexOnDiskFull.
It is happening because the while loop that checks for merge exceptions that had occurred during optimize fails to catch the case where all the BG optimize merges completed (or hit exceptions) before the while loop begins. IE, all BG threads finished before the FG thread advanced to the while loop. In that case the code fails to check if there were any exceptions.
The fix is straightforward: change the while loop so that it always checks, at least once, whether there were exceptions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1376) sometimes if a BG merge hits an
exception, optimize() will fail to forward the exception
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1376:
---------------------------------------
Attachment: LUCENE-1376.patch
Attached patch. I will commit shortly.
> sometimes if a BG merge hits an exception, optimize() will fail to forward the exception
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-1376
> URL: https://issues.apache.org/jira/browse/LUCENE-1376
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.4
>
> Attachments: LUCENE-1376.patch
>
>
> I was seeing an intermittant failure, only on a Windows instance running inside VMWare, of TestIndexWriter.testAddIndexOnDiskFull.
> It is happening because the while loop that checks for merge exceptions that had occurred during optimize fails to catch the case where all the BG optimize merges completed (or hit exceptions) before the while loop begins. IE, all BG threads finished before the FG thread advanced to the while loop. In that case the code fails to check if there were any exceptions.
> The fix is straightforward: change the while loop so that it always checks, at least once, whether there were exceptions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1376) sometimes if a BG merge hits an
exception, optimize() will fail to forward the exception
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1376.
----------------------------------------
Resolution: Fixed
Committed revision 691964.
> sometimes if a BG merge hits an exception, optimize() will fail to forward the exception
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-1376
> URL: https://issues.apache.org/jira/browse/LUCENE-1376
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.4
>
> Attachments: LUCENE-1376.patch
>
>
> I was seeing an intermittant failure, only on a Windows instance running inside VMWare, of TestIndexWriter.testAddIndexOnDiskFull.
> It is happening because the while loop that checks for merge exceptions that had occurred during optimize fails to catch the case where all the BG optimize merges completed (or hit exceptions) before the while loop begins. IE, all BG threads finished before the FG thread advanced to the while loop. In that case the code fails to check if there were any exceptions.
> The fix is straightforward: change the while loop so that it always checks, at least once, whether there were exceptions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org