You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/04/13 00:02:05 UTC
[jira] [Created] (HADOOP-7224) Add command factory to FsShell
Add command factory to FsShell
------------------------------
Key: HADOOP-7224
URL: https://issues.apache.org/jira/browse/HADOOP-7224
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.22.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7224) Add command factory to FsShell
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019449#comment-13019449 ]
Tanping Wang commented on HADOOP-7224:
--------------------------------------
+1. Dyran explained to me how
{code}
public void registerCommands(Class<?> registrarClass)
{code}
in CommandFactory.java is planned to be used and the reason why it is needed. I think it is a good idea. Please clarify here on the Jira.
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7224) Add command factory to FsShell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019782#comment-13019782 ]
Hudson commented on HADOOP-7224:
--------------------------------
Integrated in Hadoop-Common-trunk #661 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/661/])
Add the missing file TestCommandFactory for HADOOP-7224.
HADOOP-7224. Add CommandFactory to shell. Contributed by Daryn Sharp
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224-2.patch, HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7224) Add command factory to FsShell
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7224:
--------------------------------
Attachment: HADOOP-7224-2.patch
(I'm just updating comments in the patch)
The factory has a registerCommands(Class) method in order to abstract the factory's contract with its commands. Doing so will allow the api to evolve w/o impacting the caller (such as FsShell).
I eventually plan to add a method to FsShell to return the registrar class so subclasses can return their own class for commands. These subclasses will be insulated from the details of how and when the factory is initialized.
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224-2.patch, HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7224) Add command factory to FsShell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019495#comment-13019495 ]
Hadoop QA commented on HADOOP-7224:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476268/HADOOP-7224-2.patch
against trunk revision 1091618.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/347//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/347//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/347//console
This message is automatically generated.
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224-2.patch, HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7224) Add command factory to FsShell
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7224:
--------------------------------
Status: Patch Available (was: Open)
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7224) Add command factory to FsShell
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7224:
--------------------------------
Attachment: HADOOP-7224.patch
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7224) Add command factory to FsShell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019588#comment-13019588 ]
Hudson commented on HADOOP-7224:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #552 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/552/])
Add the missing file TestCommandFactory for HADOOP-7224.
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224-2.patch, HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7224) Add command factory to FsShell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019538#comment-13019538 ]
Hudson commented on HADOOP-7224:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #550 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/550/])
HADOOP-7224. Add CommandFactory to shell. Contributed by Daryn Sharp
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224-2.patch, HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7224) Add command factory to FsShell
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7224:
-------------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I have committed this. Thanks Daryn!
Also thanks Tanping for reviewing it.
> Add command factory to FsShell
> ------------------------------
>
> Key: HADOOP-7224
> URL: https://issues.apache.org/jira/browse/HADOOP-7224
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7224-2.patch, HADOOP-7224.patch
>
>
> The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira