You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Karl Wettin (JIRA)" <ji...@apache.org> on 2008/04/14 07:37:06 UTC
[jira] Created: (HADOOP-3243) DoubleWritable
DoubleWritable
--------------
Key: HADOOP-3243
URL: https://issues.apache.org/jira/browse/HADOOP-3243
Project: Hadoop Core
Issue Type: New Feature
Components: io
Reporter: Karl Wettin
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3243) DoubleWritable
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591613#action_12591613 ]
Karl Wettin commented on HADOOP-3243:
-------------------------------------
Hmm, why did I get assigned to this issue?
{quote}
Owen O'Malley reassigned HADOOP-3243:
-------------------------------------
Assignee: Karl Wettin
{quote}
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt, HADOOP-3243.txt, testfloat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3243) DoubleWritable
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated HADOOP-3243:
--------------------------------
Attachment: HADOOP-3243.txt
More or less a clone of FloatWritable.
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3243) DoubleWritable
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-3243:
---------------------------------
Attachment: testfloat.patch
> Should it test write, read, equals, hash, comparator?
TestWritable has generic code that tests read, write and equals. I've attached a patch that adds a testFloat() case there.
Testing hashCode too would be good, and best added to TestWritable, but that should probably be done in a separate issue, since it will probably uncover some classes that don't implement hashCode but that use TestWritable.
TestWritable should also test the comparator for WritableComparables, but that should also be in a separate issue.
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt, testfloat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3243) DoubleWritable
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wettin updated HADOOP-3243:
--------------------------------
Attachment: HADOOP-3243.txt
* DoubleWritable
* TestWritable#testFloatWritable()
* TestWritable#testDobleWritable()
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt, HADOOP-3243.txt, testfloat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3243) DoubleWritable
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588617#action_12588617 ]
Karl Wettin commented on HADOOP-3243:
-------------------------------------
Actually, it was just fine. I was doing something wicked.
I also got a pointer to HADOOP-3061, a near duplicate of this issue.
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3243) DoubleWritable
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588696#action_12588696 ]
Doug Cutting commented on HADOOP-3243:
--------------------------------------
Patch looks fine. Tests needed.
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3243) DoubleWritable
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588737#action_12588737 ]
Andrzej Bialecki commented on HADOOP-3243:
-------------------------------------------
For the record, HADOOP-3061 contains also unit tests.
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt, testfloat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-3243) DoubleWritable
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar resolved HADOOP-3243.
-----------------------------------
Resolution: Duplicate
Closing this issue as duplicate since, HADOOP-3061 is committed. Karl, could you please open a new jira for a test case for FloatWritable and attach the relevant patch there. Thanks !
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt, HADOOP-3243.txt, testfloat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3243) DoubleWritable
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591670#action_12591670 ]
Doug Cutting commented on HADOOP-3243:
--------------------------------------
> Hmm, why did I get assigned to this issue?
Because you've been submitting patches. We use assignee to record the primary author of a patch. That makes it easy to find out how much and what folks have contributed.
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt, HADOOP-3243.txt, testfloat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3243) DoubleWritable
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588493#action_12588493 ]
Karl Wettin commented on HADOOP-3243:
-------------------------------------
I just noticed that the comparator in the patch is bad! Sorry.
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3243) DoubleWritable
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley reassigned HADOOP-3243:
-------------------------------------
Assignee: Karl Wettin
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Assignee: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt, testfloat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3243) DoubleWritable
Posted by "Karl Wettin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588718#action_12588718 ]
Karl Wettin commented on HADOOP-3243:
-------------------------------------
{quote}
Tests needed.
{quote}
I was actually a bit surprised that I could not find a test for FloatWritable when cloning. Is it somehow late bound? Or does it simply not exist?
Should it test write, read, equals, hash, comparator?
> DoubleWritable
> --------------
>
> Key: HADOOP-3243
> URL: https://issues.apache.org/jira/browse/HADOOP-3243
> Project: Hadoop Core
> Issue Type: New Feature
> Components: io
> Reporter: Karl Wettin
> Priority: Minor
> Attachments: HADOOP-3243.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.