[GitHub] [kafka] showuon commented on a change in pull request #10805: KAFKA-12436 KIP-720 Deprecate MirrorMaker v1

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r643754484



##########
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##########
@@ -58,7 +58,11 @@ import scala.util.{Failure, Success, Try}
  *            enable.auto.commit=false
  *       3. Mirror Maker Setting:
  *            abort.on.send.failure=true
+ *
+ * @deprecated The original Mirror Maker is deprecated since release 3.0. Similar functionality can be
+ *    found in the Connect-based re-implementation by the same name (aka MM2).

Review comment:
       1. `The original Mirror Maker` -> could we say `The old Mirror Maker` ?
   2. `Similar functionality can be found in the Connect-based re-implementation by the same name (aka MM2)` -> Could we change to: `Please use Connect-based re-implementation  in org.apache.kafka.connect.mirror.MirrorMaker (aka MM2) instead.`?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org