You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/29 14:09:37 UTC
[GitHub] [skywalking-satellite] gxthrj opened a new pull request #59: feat: add Prometheus service discovery in Kubernetes
gxthrj opened a new pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59
- [x] 0.Add Prometheus service discovery in kubernetes
- [x] 1.fix: Add string type matching in overrideSlice
- [x] 2.fix: Initialize runningQueue in FetcherGatherer
- [x] 3.fix: Initialize OutputChannel in Prometheus fetcher plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#issuecomment-895976331
@gxthrj Do you add e2e test in this PR or in a separate one? We at least need it in this week, so we could include it in 0.2.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#issuecomment-889197835
Please fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#discussion_r679638420
##########
File path: configs/satellite_config.yaml
##########
@@ -247,3 +247,51 @@ pipes:
client_name: grpc-client
forwarders:
- plugin_name: nativemeter-grpc-forwarder
+ - common_config:
Review comment:
Should the fetcher pipeline be in the document only?
I think in default, we don't scratch from anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on a change in pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#discussion_r679683938
##########
File path: configs/satellite_config.yaml
##########
@@ -247,3 +247,51 @@ pipes:
client_name: grpc-client
forwarders:
- plugin_name: nativemeter-grpc-forwarder
+ - common_config:
Review comment:
OK, will move to docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#issuecomment-896118238
> @gxthrj Do you add e2e test in this PR or in a separate one? We at least need it in this week, so we could include it in 0.2.0 release.
Will add e2e test in a separate one, and try my best to make it done in this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#issuecomment-896180748
Fix https://github.com/apache/skywalking/issues/7436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#issuecomment-895976958
Changelog should be updated, https://github.com/apache/skywalking-satellite/blob/main/CHANGES.md.
There is a format issue for bug section, please fix it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#discussion_r685909351
##########
File path: configs/satellite_config.yaml
##########
@@ -247,3 +247,51 @@ pipes:
client_name: grpc-client
forwarders:
- plugin_name: nativemeter-grpc-forwarder
+ - common_config:
+ pipe_name: prometheus-fetcher
+ gatherer:
+ fetcher:
+ plugin_name: "prometheus-metrics-fetcher"
+ scrape_configs:
+ - job_name: 'prometheus'
+ metrics_path: '/metrics'
+ scrape_interval: 10s
+ static_configs:
+ - targets:
+ - "127.0.0.1:9100"
+ - job_name: 'prometheus-k8s'
+ metrics_path: '/metrics'
+ scrape_interval: 10s
+ tls_config:
+ ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
+ bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token
+ kubernetes_sd_configs:
+ - role: pod
+ selectors:
+ - role: pod
+ label: "app=prometheus"
+ relabel_configs:
+ - source_labels: [ __meta_kubernetes_pod_name ]
+ separator: ;
+ regex: (.*)
+ target_label: pod
+ replacement: $1
+ action: replace
+ queue:
+ plugin_name: "memory-queue"
+ # The maximum buffer event size.
+ event_buffer_size: ${SATELLITE_QUEUE_EVENT_BUFFER_SIZE:5000}
+ processor:
+ filters:
+ sender:
+ fallbacker:
+ plugin_name: none-fallbacker
+ # The time interval between two flush operations. And the time unit is millisecond.
+ flush_time: ${SATELLITE_LOGPIPE_SENDER_FLUSH_TIME:1000}
Review comment:
Please rename the environment key, is not the log pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on a change in pull request #59: feat: add Prometheus service discovery in Kubernetes
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-satellite/pull/59#discussion_r685917113
##########
File path: configs/satellite_config.yaml
##########
@@ -247,3 +247,51 @@ pipes:
client_name: grpc-client
forwarders:
- plugin_name: nativemeter-grpc-forwarder
+ - common_config:
+ pipe_name: prometheus-fetcher
+ gatherer:
+ fetcher:
+ plugin_name: "prometheus-metrics-fetcher"
+ scrape_configs:
+ - job_name: 'prometheus'
+ metrics_path: '/metrics'
+ scrape_interval: 10s
+ static_configs:
+ - targets:
+ - "127.0.0.1:9100"
+ - job_name: 'prometheus-k8s'
+ metrics_path: '/metrics'
+ scrape_interval: 10s
+ tls_config:
+ ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
+ bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token
+ kubernetes_sd_configs:
+ - role: pod
+ selectors:
+ - role: pod
+ label: "app=prometheus"
+ relabel_configs:
+ - source_labels: [ __meta_kubernetes_pod_name ]
+ separator: ;
+ regex: (.*)
+ target_label: pod
+ replacement: $1
+ action: replace
+ queue:
+ plugin_name: "memory-queue"
+ # The maximum buffer event size.
+ event_buffer_size: ${SATELLITE_QUEUE_EVENT_BUFFER_SIZE:5000}
+ processor:
+ filters:
+ sender:
+ fallbacker:
+ plugin_name: none-fallbacker
+ # The time interval between two flush operations. And the time unit is millisecond.
+ flush_time: ${SATELLITE_LOGPIPE_SENDER_FLUSH_TIME:1000}
Review comment:
instead with `SATELLITE_PROMETHEUS_*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org