Re: [PR] Feature/trino provider timezone [airflow]

["Lee-W (via GitHub)" <gi...@apache.org>]

Lee-W commented on code in PR #35963:
URL: https://github.com/apache/airflow/pull/35963#discussion_r1411880984


##########
airflow/providers/trino/hooks/trino.py:
##########
@@ -156,6 +156,7 @@ def get_conn(self) -> Connection:
             verify=_boolify(extra.get("verify", True)),
             session_properties=extra.get("session_properties") or None,
             client_tags=extra.get("client_tags") or None,
+            timezone=extra.get("timezone") or None,

Review Comment:
   nitpick: May I know if we need the `or None` here? I thought if "timezone" is not presented, it will return `None` by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org