[GitHub] [spark] sunchao edited a comment on pull request #33989: [SPARK-36676][SQL][BUILD] Create shaded Hive module and upgrade Guava version to 30.1.1-jre

[GitBox <gi...@apache.org>]

sunchao edited a comment on pull request #33989:
URL: https://github.com/apache/spark/pull/33989#issuecomment-926818975


   > Do we know how the Guava version upgrade will interact with the IsolatedClientLoader used for metastore clients?
   
   This also crossed my mind too. The related unit tests (e.g., `VersionsSuite`) are all happy at the moment but there could still be unknowns I'm afraid.
   
   > Maybe we can remove this from isSharedClass; I'm not sure.
   
   Yes, I'm also thinking to make guava non-shared classes here so the class loader will instead pick the ones from `hive-exec` jar (which is a fat jar with all the guava classes). Ideally `hive-exec` should shade Guava by itself but this is only done in the latest 2.3.x and master. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org