You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pussuw (via GitHub)" <gi...@apache.org> on 2023/03/04 20:51:24 UTC

[GitHub] [nuttx] pussuw commented on pull request #8605: signal/sig_dispatch: Fix case where signal action is sent twice

pussuw commented on PR #8605:
URL: https://github.com/apache/nuttx/pull/8605#issuecomment-1454871336

   I'm sorry to hear that you encountered a regression.
   
   As far as I can understand how posix signals are supposed to work, this should have fixed the  situation where the signal action is never performed if the signal is masked, or if system calls are in use.
   
   My understanding of the posix signaling spec is that if a signal action is masked, it should be put into the pending queue no matter what. I am not sure about this though. Maybe someone who knows more about this subject can comment?
   
   @xiaoxiang781216 the revert should take into account what this patch was supposed to fix; the signal action should not be pended twice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org