Re: [PR] [SPARK-49152][SQL] V2SessionCatalog should use V2Command [spark]

["manuzhang (via GitHub)" <gi...@apache.org>]

manuzhang commented on code in PR #47724:
URL: https://github.com/apache/spark/pull/47724#discussion_r1766105982


##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -579,6 +581,18 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
   }
 
   object ResolvedV1Identifier {
+    def unapply(resolved: LogicalPlan): Option[TableIdentifier] = resolved match {
+      case ResolvedIdentifier(catalog, ident) if supportsV1Command(catalog) =>

Review Comment:
   @amaliujia @cloud-fan 
   This change looks to have broken creating V1 table from a `V2_SESSION_CATALOG_IMPLEMENTATION` like [Iceberg's SparkSessionCatalog](https://iceberg.apache.org/docs/nightly/spark-configuration/#replacing-the-session-catalog)
   
   https://github.com/apache/spark/blob/e693e18c7d0e9a495dcb6e9b31dac9ce2b98428c/sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala#L159-L170
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org