You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2018/04/20 16:58:01 UTC
hbase git commit: HBASE-20438 Add an HBase antipattern check for
reintroducing commons-logging
Repository: hbase
Updated Branches:
refs/heads/master 4e183748c -> 8219ec749
HBASE-20438 Add an HBase antipattern check for reintroducing commons-logging
Signed-off-by: Sean Busbey <bu...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/8219ec74
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/8219ec74
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/8219ec74
Branch: refs/heads/master
Commit: 8219ec749331eb163060f5ffbeedd8ae826ebfe1
Parents: 4e18374
Author: Nihal Jain <ni...@gmail.com>
Authored: Wed Apr 18 23:03:07 2018 +0530
Committer: Sean Busbey <bu...@apache.org>
Committed: Fri Apr 20 11:54:01 2018 -0500
----------------------------------------------------------------------
dev-support/hbase-personality.sh | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/8219ec74/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 2198913..b010503 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -642,6 +642,12 @@ function hbaseanti_patchfile
((result=result+1))
fi
+ warnings=$(${GREP} -cE 'org.apache.commons.logging.Log(Factory|;)' "${patchfile}")
+ if [[ ${warnings} -gt 0 ]]; then
+ add_vote_table -1 hbaseanti "" "The patch appears to use commons-logging instead of slf4j."
+ ((result=result+1))
+ fi
+
if [[ ${result} -gt 0 ]]; then
return 1
fi