[jira] [Commented] (MPLUGIN-305) MojoAnnotationsScanner should have better control over dependency scanning

["Hervé Boutemy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPLUGIN-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314268#comment-16314268 ] 

Hervé Boutemy commented on MPLUGIN-305:
---------------------------------------

working on MPLUGIN-330, I read this issue that I completely overlooked at the time it was done

I understand that filtering dependencies can be done, since clearly very few dependencies have a chance to contribute to Mojo.

Question: but what is the objective of this filtering? performance? failures that happened when scanning not useful dependencies?

Notice: I find the name ot the parameter "mojoDependencies" a little bit misleading: the notion of "filtering" could be useful, since you're not specifying dependencies (if you configure a value that is not an effective dependency, it won't be added). And "scan" or "extract" also would be useful
I know it's a bit late and changing won't be easy, but with {{mojoDependencies}} name, I fear the feature is hard to find/understand.
At least I'll try to add details in the parameter documentation

> MojoAnnotationsScanner should have better control over dependency scanning
> --------------------------------------------------------------------------
>
>                 Key: MPLUGIN-305
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-305
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>          Components: maven-plugin-tools-annotations
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>            Priority: Minor
>             Fix For: 3.5
>
>
> Currently MojoAnnotationsScanner always scans all dependencies in search for Mojo's. However, most of the time there's no need to do so: the sources are all the mojo's for the plugin.
> The simple solution would be to specify if the plugin should scan, and maybe even which dependencies.
> A more elegant way would be to analyze the source-classes. If the Mojo's extend known classes like AbstractMojo, there's no need to scan at all.
> ps. plugins which require dependencies-scanning are the maven-surefire-plugin and maven-failsafe-plugin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)