[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1580: MINIFICPP-2126 Use sccache and Ninja in Windows CI

["lordgamez (via GitHub)" <gi...@apache.org>]

lordgamez commented on code in PR #1580:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1580#discussion_r1211858683


##########
.github/workflows/ci.yml:
##########
@@ -73,8 +74,15 @@ jobs:
         run: git config --system core.longpaths true
       - id: checkout
         uses: actions/checkout@v3
-      - name: Set up MSBuild
-        uses: microsoft/setup-msbuild@v1.1
+      - name: Run sccache-cache
+        uses: mozilla-actions/sccache-action@v0.0.3
+      - name: sccache cache
+        uses: actions/cache@v3
+        with:
+          path: ~/AppData/Local/Mozilla/sccache/cache
+          key: ${{ runner.os }}-sccache

Review Comment:
   We could use github ref and hash specific caches here as well similarly to other build caches, that would probably result in more cache hits for job runs on specific branches:
   ```
   key: windows-sccache-${{github.ref}}-${{github.sha}}
   restore-keys: |
     windows-sccache-${{github.ref}}-
     windows-sccache-refs/heads/main-
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org