[jira] [Commented] (CASSANDRA-18940) SAI post-filtering reads don't update local table latency metrics

["Ekaterina Dimitrova (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817133#comment-17817133 ] 

Ekaterina Dimitrova commented on CASSANDRA-18940:
-------------------------------------------------

Any thoughts what we do with this one? It is marked 5.0 blocker

> SAI post-filtering reads don't update local table latency metrics
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-18940
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18940
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/2i Index, Feature/SAI, Observability/Metrics
>            Reporter: Caleb Rackliffe
>            Assignee: Mike Adamson
>            Priority: Normal
>             Fix For: 5.0-rc, 5.x
>
>         Attachments: draft_fix_for_SAI_post-filtering_reads_not_updating_local_table_metrics.patch
>
>
> Once an SAI index finds matches (primary keys), it reads the associated rows and post-filters them to incorporate partial writes, tombstones, etc. However, those reads are not currently updating the local table latency metrics. It should be simple enough to attach a metrics recording transformation to the iterator produced by querying local storage. (I've attached a patch that should apply cleanly to trunk, but there may be a better way...)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org