You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/29 00:30:03 UTC
[GitHub] [airflow] kaxil opened a new pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
kaxil opened a new pull request #13963:
URL: https://github.com/apache/airflow/pull/13963
closes https://github.com/apache/airflow/issues/13434
Currently, manual dag runs are causing catchups to fail and also skip the next dag run because `dag_model.next_dagrun` was set incorrectly
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13963:
URL: https://github.com/apache/airflow/pull/13963#issuecomment-770197783
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Naresh-sin commented on pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
Naresh-sin commented on pull request #13963:
URL: https://github.com/apache/airflow/pull/13963#issuecomment-790627008
Guys Need help.Sorry by bad did not understand what is the fix to do for Manual DagRun trigger skip actual schedule?
what I get from here is remove the line DagRun.external_trigger.is_(True) from airflow/models/dag.py is that so?
or I need to change any config in my dag file?
@kaxil Please suggest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13963:
URL: https://github.com/apache/airflow/pull/13963#issuecomment-820811413
> Guys Need help.Sorry by bad did not understand what is the fix to do for Manual DagRun trigger skip actual schedule?
> what I get from here is remove the line DagRun.external_trigger.is_(True) from airflow/models/dag.py is that so?
> or I need to change any config in my dag file?
> @kaxil Please suggest.
> I am using airflow version ARG AIRFLOW_VERSION=1.10.12
That is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13963:
URL: https://github.com/apache/airflow/pull/13963#issuecomment-769525169
[The Workflow run](https://github.com/apache/airflow/actions/runs/519686140) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhanu-prakash3 commented on pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
bhanu-prakash3 commented on pull request #13963:
URL: https://github.com/apache/airflow/pull/13963#issuecomment-1033408247
Hello, I'm using Airflow version 2.2.3 and still facing this issue. My DAG is scheduled to run "@daily". I manually triggered the Dag yesterday(**2022-02-08, 09:19:22**) and I expect it to be scheduled Today at **2022-02-09, 00:00:00**, but the DAG was not scheduled.
From the below image:
The last run was on 2022-02-08, 09:19:22 and the next run is scheduled at 2022-02-09, 00:00:00. But the time has already passed and it is 2022-02-09 06:22 UTC
DAG parameters:
```
{'catchup': False,
'catchup_by_default': False,
'depends_on_past': False,
'provide_context': True,
'retries': 1,
'retry_delay': datetime.timedelta(0, 300),
'start_date': DateTime(2021, 12, 31, 15, 50, 0, tzinfo=Timezone('UTC'))}
```
Do I need to change any parameters or config values? Please suggest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Naresh-sin edited a comment on pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
Naresh-sin edited a comment on pull request #13963:
URL: https://github.com/apache/airflow/pull/13963#issuecomment-790627008
Guys Need help.Sorry by bad did not understand what is the fix to do for Manual DagRun trigger skip actual schedule?
what I get from here is remove the line DagRun.external_trigger.is_(True) from airflow/models/dag.py is that so?
or I need to change any config in my dag file?
@kaxil Please suggest.
I am using airflow version ARG AIRFLOW_VERSION=1.10.12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13963:
URL: https://github.com/apache/airflow/pull/13963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhanu-prakash3 edited a comment on pull request #13963: Bugfix: Manual DagRun trigger should not skip scheduled runs
Posted by GitBox <gi...@apache.org>.
bhanu-prakash3 edited a comment on pull request #13963:
URL: https://github.com/apache/airflow/pull/13963#issuecomment-1033408247
Hello, I'm using Airflow version 2.2.3 and still facing this issue. My DAG is scheduled to run "@daily". I manually triggered the Dag yesterday(**2022-02-08, 09:19:22**) and I expect it to be scheduled Today at **2022-02-09, 00:00:00**, but the DAG was not scheduled.
From the below image:
The last run was on 2022-02-08, 09:19:22 and the next run is scheduled at 2022-02-09, 00:00:00. But the time has already passed and it is 2022-02-09 06:22 UTC
DAG parameters:
```
{'catchup': False,
'catchup_by_default': False,
'depends_on_past': False,
'provide_context': True,
'retries': 1,
'retry_delay': datetime.timedelta(0, 300),
'start_date': DateTime(2021, 12, 31, 15, 50, 0, tzinfo=Timezone('UTC'))}
```
Do I need to change any parameters or config values? Please suggest
@kaxil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org