You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/09/03 10:41:24 UTC

svn commit: r810814 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/entry/catalog/productsummary.ftl

Author: jleroux
Date: Thu Sep  3 08:41:24 2009
New Revision: 810814

URL: http://svn.apache.org/viewvc?rev=810814&view=rev
Log:
A patch from Carsten Schinzer "ordermgr webapp - catalog - productsummary contains hard coded labels" (https://issues.apache.org/jira/browse/OFBIZ-OFBIZ-2856) - OFBIZ-2856

Modified:
    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
    ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl

Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=810814&r1=810813&r2=810814&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
+++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu Sep  3 08:41:24 2009
@@ -10455,5 +10455,15 @@
     <property key="OrderShipToCountry">
         <value xml:lang="en">Ship to Country</value>
     </property>
+    <property key="SizeAvailableSingle">
+        <value xml:lang="de">Größe</value>
+        <value xml:lang="en">Size</value>
+        <value xml:lang="fr">Taille</value>
+    </property>
+    <property key="SizeAvailableMultiple">
+        <value xml:lang="de">Verfügbare Größen</value>
+        <value xml:lang="en">Sizes Available</value>
+        <value xml:lang="fr">Tailles Disponibles</value>
+    </property>
 
 </resource>

Modified: ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl?rev=810814&r1=810813&r2=810814&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl (original)
+++ ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl Thu Sep  3 08:41:24 2009
@@ -103,9 +103,9 @@
           <#if sizeProductFeatureAndAppls?has_content>
             <div>
               <#if (sizeProductFeatureAndAppls?size == 1)>
-                Size:
+                ${uiLabelMap.SizeAvailableSingle}:
               <#else>
-                Sizes Available:
+                ${uiLabelMap.SizeAvailableMultiple}:
               </#if>
               <#list sizeProductFeatureAndAppls as sizeProductFeatureAndAppl>
                 ${sizeProductFeatureAndAppl.abbrev?default(sizeProductFeatureAndAppl.description?default(sizeProductFeatureAndAppl.productFeatureId))}<#if sizeProductFeatureAndAppl_has_next>,</#if>

Re: svn commit: r810814 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/entry/catalog/productsummary.ftl

Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Vikas,

Yes, and ASAS you have a serious look at this kind of stuff, plenty others surge. Have a look at for instance at r810870

BTW, we should use more the Webtools/Label Manager, even if there are still some quirks to fix there (for instance to intiate the 
process)

Thanks

Jacques

From: "Vikas Mayur" <vi...@hotwaxmedia.com>
Just wanted to know when to prefix the component name with the key.
AFAIK, the labels except those with prefix FormFieldTitle_ starts with
the component name.

Vikas

On Sep 3, 2009, at 2:11 PM, jleroux@apache.org wrote:

> Author: jleroux
> Date: Thu Sep  3 08:41:24 2009
> New Revision: 810814
>
> URL: http://svn.apache.org/viewvc?rev=810814&view=rev
> Log:
> A patch from Carsten Schinzer "ordermgr webapp - catalog -  productsummary contains hard coded labels" 
> (https://issues.apache.org/jira/browse/OFBIZ-OFBIZ-2856 ) - OFBIZ-2856
>
> Modified:
>    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>    ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/ productsummary.ftl
>
> Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=810814&r1=810813&r2=810814&view=diff
> = = = = = = = = ======================================================================
> --- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
> +++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu Sep   3 08:41:24 2009
> @@ -10455,5 +10455,15 @@
>     <property key="OrderShipToCountry">
>         <value xml:lang="en">Ship to Country</value>
>     </property>
> +    <property key="SizeAvailableSingle">
> +        <value xml:lang="de">GröÃYe</value>
> +        <value xml:lang="en">Size</value>
> +        <value xml:lang="fr">Taille</value>
> +    </property>
> +    <property key="SizeAvailableMultiple">
> +        <value xml:lang="de">Verfügbare GröÃYen</value>
> +        <value xml:lang="en">Sizes Available</value>
> +        <value xml:lang="fr">Tailles Disponibles</value>
> +    </property>

Re: svn commit: r810814 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/entry/catalog/productsummary.ftl

Posted by Vikas Mayur <vi...@hotwaxmedia.com>.
Just wanted to know when to prefix the component name with the key.  
AFAIK, the labels except those with prefix FormFieldTitle_ starts with  
the component name.

Vikas

On Sep 3, 2009, at 2:11 PM, jleroux@apache.org wrote:

> Author: jleroux
> Date: Thu Sep  3 08:41:24 2009
> New Revision: 810814
>
> URL: http://svn.apache.org/viewvc?rev=810814&view=rev
> Log:
> A patch from Carsten Schinzer "ordermgr webapp - catalog -  
> productsummary contains hard coded labels" (https://issues.apache.org/jira/browse/OFBIZ-OFBIZ-2856 
> ) - OFBIZ-2856
>
> Modified:
>    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>    ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/ 
> productsummary.ftl
>
> Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=810814&r1=810813&r2=810814&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
> +++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu Sep   
> 3 08:41:24 2009
> @@ -10455,5 +10455,15 @@
>     <property key="OrderShipToCountry">
>         <value xml:lang="en">Ship to Country</value>
>     </property>
> +    <property key="SizeAvailableSingle">
> +        <value xml:lang="de">Größe</value>
> +        <value xml:lang="en">Size</value>
> +        <value xml:lang="fr">Taille</value>
> +    </property>
> +    <property key="SizeAvailableMultiple">
> +        <value xml:lang="de">Verfügbare Größen</value>
> +        <value xml:lang="en">Sizes Available</value>
> +        <value xml:lang="fr">Tailles Disponibles</value>
> +    </property>