You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/04/13 20:48:36 UTC
[GitHub] [avro] KyleSchoonover opened a new pull request, #1642: AVRO-3488 Fix spelling mistakes
KyleSchoonover opened a new pull request, #1642:
URL: https://github.com/apache/avro/pull/1642
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3488
### Tests
- [ ] My PR does not need testing for this extremely good reason: Non functional changes
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1642: AVRO-3488 Fix spelling mistakes
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on PR #1642:
URL: https://github.com/apache/avro/pull/1642#issuecomment-1098497500
Nice PR. Mark it for `1.12.0`, in case we are paranoid about the exception text change in a minor release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1642: AVRO-3488 Fix spelling mistakes
Posted by GitBox <gi...@apache.org>.
martin-g merged PR #1642:
URL: https://github.com/apache/avro/pull/1642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on a diff in pull request #1642: AVRO-3488 Fix spelling mistakes
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on code in PR #1642:
URL: https://github.com/apache/avro/pull/1642#discussion_r849905408
##########
lang/csharp/src/apache/main/IO/BinaryDecoder.netstandard2.0.cs:
##########
@@ -34,7 +34,7 @@ public partial class BinaryDecoder
/// <summary>
/// A float is written as 4 bytes.
/// The float is converted into a 32-bit integer using a method equivalent to
- /// Java's floatToIntBits and then encoded in little-endian format.
+ /// Java's floatToIntBits and then encoded in little-little-endian format.
Review Comment:
fix the fix plz :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1642: AVRO-3488 Fix spelling mistakes
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1642:
URL: https://github.com/apache/avro/pull/1642#issuecomment-1098770201
Thank you, @KyleSchoonover !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a diff in pull request #1642: AVRO-3488 Fix spelling mistakes
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on code in PR #1642:
URL: https://github.com/apache/avro/pull/1642#discussion_r849910478
##########
lang/csharp/src/apache/main/IO/BinaryDecoder.netstandard2.0.cs:
##########
@@ -34,7 +34,7 @@ public partial class BinaryDecoder
/// <summary>
/// A float is written as 4 bytes.
/// The float is converted into a 32-bit integer using a method equivalent to
- /// Java's floatToIntBits and then encoded in little-endian format.
+ /// Java's floatToIntBits and then encoded in little-little-endian format.
Review Comment:
There is always one. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org