[GitHub] [spark] liang3zy22 commented on a diff in pull request #40817: [SPARK-42845][SQL] Update the error class _LEGACY_ERROR_TEMP_2010 to MERGE_UNSUPPORTED_BY_WINDOW_FUNCTION

["liang3zy22 (via GitHub)" <gi...@apache.org>]

liang3zy22 commented on code in PR #40817:
URL: https://github.com/apache/spark/pull/40817#discussion_r1174846714


##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -858,6 +858,15 @@ class QueryExecutionErrorsSuite
           "any enclosing class nor any supertype")),
       sqlState = "XX000")
   }
+
+  test("SPARK-42845: merge unsupported by aggregate window function") {
+    checkError(
+      intercept[SparkUnsupportedOperationException]{
+        RowNumber().mergeExpressions

Review Comment:
   I can't find a method to trigger this error_class using SQL statement. This error_class are only thrown by "mergeExpressions" field of AggregateWindowFunction. But this field isn't called anywhere in all aggregate window function. Maybe we can change it to internal error?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org