You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/22 20:00:52 UTC

[GitHub] [maven-archetype] MarianMacik opened a new pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

MarianMacik opened a new pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86


   … Maven settings from the main build
   
   [ARCHETYPE-622](https://issues.apache.org/jira/browse/ARCHETYPE-622)
   
   Hi @hboutemy,
   
   can you please look at the PR? I think it may be good to unify the behaviour of maven-archetype-plugin:integration-test with the invoker in terms of settings.xml consumption. Otherwise when one tries to make it behave the same, unnecessary workarounds are needed. I have also included a test which tests that the correct settings were passed to the archetype by checking the download output of the build.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] MarianMacik commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

MarianMacik commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-980432046


   @slachiewicz Sorry to bother you again, but 3 combinations failed because of unrelated issues. Can you retrigger? It must be some infrastructure issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] MarianMacik commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

MarianMacik commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-980420050


   Test failure is resolved now. I was counting on the fact that everything will be downloaded from the local repository but turned out some artifacts still need to be downloaded. I came up with an even better check to actually check Maven debug output for the correct settings file. Can anybody retrigger the PR check, please? Thanks!
   
   @hboutemy @rfscholte @olamy @slachiewicz


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] MarianMacik commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

MarianMacik commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-979928848


   @hboutemy @rfscholte @olamy Can anyone from you approve rerunning the workflow? I added some debug information to understand why tests work locally but don't on GitHub. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] MarianMacik commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

MarianMacik commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-980435929


   @slachiewicz Thanks! It's green now! Can you merge it or should I write somewhere to the mailing list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] slachiewicz commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

slachiewicz commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-980436765


   Let me review it here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] MarianMacik commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

MarianMacik commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-984146416


   @slachiewicz Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] MarianMacik commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

MarianMacik commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-977644556


   @hboutemy @rfscholte @olamy Can any of you have a look at this PR? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] MarianMacik commented on pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

MarianMacik commented on pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86#issuecomment-979930687


   @slachiewicz I noticed you approved running it last time, can you retrigger it, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-archetype] slachiewicz merged pull request #86: [ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use…

Posted by GitBox <gi...@apache.org>.

slachiewicz merged pull request #86:
URL: https://github.com/apache/maven-archetype/pull/86


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org