You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/28 05:46:30 UTC

[GitHub] [apisix-dashboard] ShiningRush opened a new pull request #899: chore: add middleware to transform error and rename placeholder.txt

ShiningRush opened a new pull request #899:
URL: https://github.com/apache/apisix-dashboard/pull/899


   - Add middleware to transform error, resolve #568 
   - Rename `placeholder.txt` to `.gitkeep`, It is more suitable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta commented on pull request #899: chore: add middleware to transform error and rename placeholder.txt

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #899:
URL: https://github.com/apache/apisix-dashboard/pull/899#issuecomment-735586190


   > @ShiningRush I found that you only added test cases to the routed (uri). should we add test cases in these situations? [#568 (comment)](https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715)
   
   I have tested the problematic scenes, and there are indeed no problems.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #899: chore: add middleware to transform error and rename placeholder.txt

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #899:
URL: https://github.com/apache/apisix-dashboard/pull/899#issuecomment-735044453


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/899?src=pr&el=h1) Report
   > Merging [#899](https://codecov.io/gh/apache/apisix-dashboard/pull/899?src=pr&el=desc) (4766942) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/277ae594b213c1c0bfb9aa0d387622cc9c65a6cc?el=desc) (277ae59) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/899/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/899?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #899   +/-   ##
   =======================================
     Coverage   43.03%   43.03%           
   =======================================
     Files          18       18           
     Lines        1271     1271           
   =======================================
     Hits          547      547           
     Misses        632      632           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/899?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/899?src=pr&el=footer). Last update [277ae59...4766942](https://codecov.io/gh/apache/apisix-dashboard/pull/899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen merged pull request #899: chore: add middleware to transform error and rename placeholder.txt

Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #899:
URL: https://github.com/apache/apisix-dashboard/pull/899


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] idbeta commented on pull request #899: chore: add middleware to transform error and rename placeholder.txt

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #899:
URL: https://github.com/apache/apisix-dashboard/pull/899#issuecomment-735545879


   @ShiningRush I found that you only added test cases to the routed (uri).  should we add test cases in these situations? https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org