You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/15 03:01:15 UTC
[GitHub] [incubator-streampark] 1996fanrui opened a new pull request, #1843: [Feature] Add the team_admin role
1996fanrui opened a new pull request, #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843
## What changes were proposed in this pull request
Issue Number: close #1730
Add the team_admin role, the Team Admin has all permissions inside the team.
## Brief change log
Add the team_admin role.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1843: [Feature] Add the team_admin role
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843#issuecomment-1279758625
> LGTM Thanks for your hard work, great feature. BTW, The use documents of team also need to be supplemented!
@wolfboys Thanks for your review and reminder. I will start sort out the team related doc next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on a diff in pull request #1843: [Feature] Add the team_admin role
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on code in PR #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843#discussion_r996287570
##########
streampark-console/streampark-console-service/src/assembly/script/data/mysql-data.sql:
##########
@@ -110,6 +110,7 @@ insert into `t_menu` values (100053, 100001, 'types', null, null, 'user:types',
-- Records of t_role
-- ----------------------------
insert into `t_role` values (100001, 'developer', 'developer', now(), now(), null);
+insert into `t_role` values (100002, 'team_admin', 'Team Admin has all permissions inside the team.', now(), now(), null);
Review Comment:
Hi @wolfboys , thanks for your review, it's a good idea.
I have a little concern. To facilitate managing jobs, a team may have multiple `team_admin`, including some developers.
`team_leader` represents the leader of the team. There may be some ambiguity here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1843: [Feature] Add the team_admin role
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843#issuecomment-1279645340
Hi @wolfboys , I have added the team_admin in the PR. Please help take a look in your free time, thanks a lot~
BTW, there is a problem need to be improved:
Currently, the permission isn't changed when switch to other team. For example, user_a is a developer of team_1, and he is a team_admin of team_2. When choose team from team_1 to team_2, the front-end should get the correct permissions from backend.
I created the #1844 to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1843: [Feature] Add the team_admin role
Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843#discussion_r996272135
##########
streampark-console/streampark-console-service/src/assembly/script/data/mysql-data.sql:
##########
@@ -110,6 +110,7 @@ insert into `t_menu` values (100053, 100001, 'types', null, null, 'user:types',
-- Records of t_role
-- ----------------------------
insert into `t_role` values (100001, 'developer', 'developer', now(), now(), null);
+insert into `t_role` values (100002, 'team_admin', 'Team Admin has all permissions inside the team.', now(), now(), null);
Review Comment:
how about team_admin change to team_leader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1843: [Feature] Add the team_admin role
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843#issuecomment-1279717911
> hi fanrui:
>
> The current pr does not reflect how to assign an team_admin roles to a team (team members are set to the specific implementation of the team_admin, will involve the front-end and back-end), a team is only set up one team_admin or can be set up more than one? Do you have any plans for this?
Hi @wolfboys
As I understand, if a team just have a `team_admin`, it cannot guarantee high availability😂. In other word, StreamPark also can have some System Admin.
So I prefer a team can have multiple `team_admin`, and a team can haven't `team_admin`. If we use the plan, the front-end and back-end don't need change any code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #1843: [Feature] Add the team_admin role
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843#issuecomment-1279691502
Thanks for your contribution, I'll review it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #1843: [Feature] Add the team_admin role
Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1843:
URL: https://github.com/apache/incubator-streampark/pull/1843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org