You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/26 18:35:10 UTC
[GitHub] [spark] srowen commented on issue #24712: [SPARK-27843][SQL] Remove
duplicate logic of calculate table size
srowen commented on issue #24712: [SPARK-27843][SQL] Remove duplicate logic of calculate table size
URL: https://github.com/apache/spark/pull/24712#issuecomment-496021725
I don't know this part well. It looks like the logic is similar, but reasonably different. You're pretty confident this gives the same answer? is it covered by tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org