You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/07 11:46:30 UTC

[GitHub] larroy commented on issue #10951: [MXNET-545] Fix broken cython build

larroy commented on issue #10951: [MXNET-545] Fix broken cython build
URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-445208876
 
 
   Do we have a bug tracking the segfault with openmp? 
   
   The PR looks ok to me, even though I'm not familiar with cython. I think if you add some motivation to the description of the PR explaining why is this needed and some measure if it makes things faster would help the reviewers understand better the PR.
   
   Another question is, this option is not available in the CMake system, shall we add it, but mark it as broken so we don't have divergent builds between Make & CMake?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services