You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "lgoldstein (via GitHub)" <gi...@apache.org> on 2023/09/18 17:23:10 UTC
[GitHub] [mina-sshd] lgoldstein opened a new pull request, #416: [SSHD-1330] Using common keep-alive global request handler in client as well as server
lgoldstein opened a new pull request, #416:
URL: https://github.com/apache/mina-sshd/pull/416
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on pull request #416: [SSHD-1330] Using common keep-alive global request handler in client as well as server
Posted by "lgoldstein (via GitHub)" <gi...@apache.org>.
lgoldstein commented on PR #416:
URL: https://github.com/apache/mina-sshd/pull/416#issuecomment-1724046203
@tomaswolf Please review and merge if you are satisfied - thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf merged pull request #416: [SSHD-1330] Using common keep-alive global request handler in client as well as server
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf merged PR #416:
URL: https://github.com/apache/mina-sshd/pull/416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf commented on pull request #416: [SSHD-1330] Using common keep-alive global request handler in client as well as server
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #416:
URL: https://github.com/apache/mina-sshd/pull/416#issuecomment-1730336860
Moving the `KeepAliveHandler` to a different package will break any code that currently references it using the old package. Not sure how to deal with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on pull request #416: [SSHD-1330] Using common keep-alive global request handler in client as well as server
Posted by "lgoldstein (via GitHub)" <gi...@apache.org>.
lgoldstein commented on PR #416:
URL: https://github.com/apache/mina-sshd/pull/416#issuecomment-1730781826
Valid point, but IMO
* The change is minor - package shift - so easily fixed whenever the referencing code is re-compiled with the new version
* I doubt there is much existing code referencing it directly
* Not the first time we shifted some classes + not something we are doing often
In view of this I think we can safely merge this piece of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org